OCPBUGS-44167: Ensure rendezvousIP is checked against host IP

[bfournie]

The rendezvousIP is currently checked against any substring in the nmstate configuration which can result in validation failure if the next-hop-address matches the rendezvousIP. Ensure that the check is against the host IP.

[openshift-ci-robot]

@bfournie: No Jira issue with key sOCPBUGS-44167 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

The rendezvousIP is currently checked against any substring in the nmstate configuration which can result in validation failure if the next-hop-address matches the rendezvousIP. Ensure that the check is against the host IP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@bfournie: This pull request references Jira Issue OCPBUGS-44167, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The rendezvousIP is currently checked against any substring in the nmstate configuration which can result in validation failure if the next-hop-address matches the rendezvousIP. Ensure that the check is against the host IP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/retest

[bfournie]

/retest

[pawanpinjarkar]

/lgtm

[andfasano]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/asset/agent/OWNERS [andfasano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pawanpinjarkar]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c093891 and 2 for PR HEAD 2f10e80 in total

[openshift-ci]

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@bfournie: Jira Issue OCPBUGS-44167: All pull requests linked via external trackers have merged:

• openshift/installer#9167

Jira Issue OCPBUGS-44167 has been moved to the MODIFIED state.

In response to this:

The rendezvousIP is currently checked against any substring in the nmstate configuration which can result in validation failure if the next-hop-address matches the rendezvousIP. Ensure that the check is against the host IP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@bfournie: #9167 failed to apply on top of branch "release-4.17":

Applying: OCPBUGS-44167: Ensure rendezvousIP is checked against host IP
Using index info to reconstruct a base tree...
M	pkg/asset/agent/common.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/asset/agent/common.go
CONFLICT (content): Merge conflict in pkg/asset/agent/common.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-44167: Ensure rendezvousIP is checked against host IP

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.