Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-34974: IBMCloud: Add service overrides #9156

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cjschaef
Copy link
Member

Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-34974

Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-34974
Bump the IBM Cloud TF plugin commit to pull in required
changes for COS endpoint configuration.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 30, 2024
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-34974, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-34974

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdodson for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-ovn be441dc link false /test e2e-ibmcloud-ovn
ci/prow/e2e-openstack-proxy be441dc link false /test e2e-openstack-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cjschaef
Copy link
Member Author

/jira refresh

e2e-ibmcloud-ovn failure due to know issue: https://issues.redhat.com/browse/OCPBUGS-42869
Sounds like it is related to etcd issues, unrelated to this PR's changes.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 31, 2024
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-34974, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

In response to this:

/jira refresh

e2e-ibmcloud-ovn failure due to know issue: https://issues.redhat.com/browse/OCPBUGS-42869
Sounds like it is related to etcd issues, unrelated to this PR's changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 31, 2024
@openshift-ci openshift-ci bot requested a review from MayXuQQ October 31, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants