Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.17] OCPBUGS-43897: Revendor assisted service external platform oci #9147

Conversation

pawanpinjarkar
Copy link
Contributor

Revendor Assisted Service in the installer to incorporate changes for external platform support.

@pawanpinjarkar pawanpinjarkar changed the title Revendor assisted service external platform oci 4.17 AGENT-1024: Revendor assisted service external platform oci 4.17 Oct 28, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 28, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2024

@pawanpinjarkar: This pull request references AGENT-1024 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.z" version, but no target version was set.

In response to this:

Revendor Assisted Service in the installer to incorporate changes for external platform support.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from barbacbd and rwsu October 28, 2024 17:32
@pawanpinjarkar
Copy link
Contributor Author

/jira-refresh

@pawanpinjarkar pawanpinjarkar changed the title AGENT-1024: Revendor assisted service external platform oci 4.17 OCPBUGS-43897: Revendor assisted service external platform oci Oct 28, 2024
@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-43897, which is invalid:

  • expected the bug to target only the "4.17.z" version, but multiple target versions were set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-43897 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Revendor Assisted Service in the installer to incorporate changes for external platform support.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 28, 2024
@pawanpinjarkar pawanpinjarkar force-pushed the revendor-assisted-service-external-platform-oci-4.17 branch from cb52ec4 to 055f81b Compare October 28, 2024 19:15
@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-43897, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-43897 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar pawanpinjarkar force-pushed the revendor-assisted-service-external-platform-oci-4.17 branch from 055f81b to 1291c76 Compare October 29, 2024 00:12
@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-43897, which is invalid:

  • expected Jira Issue OCPBUGS-43897 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 29, 2024
@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-43897, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-43904 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-43904 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @mhanss

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mhanss October 29, 2024 00:16
@pawanpinjarkar
Copy link
Contributor Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@pawanpinjarkar: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pawanpinjarkar pawanpinjarkar changed the title OCPBUGS-43897: Revendor assisted service external platform oci [release-4.17] OCPBUGS-43897: Revendor assisted service external platform oci Oct 29, 2024
@zaneb
Copy link
Member

zaneb commented Oct 29, 2024

/approve
/label backport-risk-assessed
/retest

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 29, 2024
Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bfournie
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@pamoedom
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d0e777f into openshift:release-4.17 Oct 29, 2024
25 checks passed
@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: Jira Issue OCPBUGS-43897: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43897 has been moved to the MODIFIED state.

In response to this:

Revendor Assisted Service in the installer to incorporate changes for external platform support.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@pawanpinjarkar: #9147 failed to apply on top of branch "release-4.16":

Applying: OCPBUGS-43897: Re-vendor assisted service https://github.com/openshift/assisted-service/commit/d41f53691d6e19b87fb5adffdb88ce3568fb0c82
.git/rebase-apply/patch:4987: trailing whitespace.
// Chain creates a simple new go-funk.Builder from a collection. Each method 
.git/rebase-apply/patch:5017: trailing whitespace.
// LazyChainWith creates a lazy go-funk.Builder from a generator. Like LazyChain, each 
.git/rebase-apply/patch:5020: trailing whitespace.
// With LazyChainWith, to can create a generic pipeline of collection transformation and, 
warning: 3 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-43897: Re-vendor assisted service https://github.com/openshift/assisted-service/commit/d41f53691d6e19b87fb5adffdb88ce3568fb0c82

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.17.0-202410291537.p0.gd0e777f.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.17.0-202410291537.p0.gd0e777f.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.17.0-202410291537.p0.gd0e777f.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.17.0-202410291537.p0.gd0e777f.assembly.stream.el9.
All builds following this will include this PR.

@pawanpinjarkar
Copy link
Contributor Author

Jira Issue OCPBUGS-43897

Manually cherrypicked via #9150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants