MULTIARCH-5150: Pass IAM endpoint override to PowerVS CloudProviderConfig #9143
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
miyamotoh
force-pushed
the
pass-iam-endpoint-override-to-cloud-provider-config
branch
from
e458482
to
15f310b
Compare
Signed-off-by: Hiro Miyamoto <[email protected]>
miyamotoh
force-pushed
the
pass-iam-endpoint-override-to-cloud-provider-config
branch
from
15f310b
to
32d6f3f
Compare
miyamotoh
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| @@ -88,4 +103,5 @@ powerVSCloudInstanceID = {{.Provider.PowerVSCloudInstanceID}} | |||
| powerVSCloudInstanceName = {{.Provider.PowerVSCloudInstanceName}} | |||
| powerVSRegion = {{.Provider.PowerVSRegion}} | |||
| powerVSZone = {{.Provider.PowerVSZone}} | |||
| iamEndpointOverride = {{.Provider.IamEndpointOverride}} | |||
There was a problem hiding this comment.
Can you confirm that having this empty worked for external clusters?
There was a problem hiding this comment.
Well, I have a 10-day-old evidence that the empty iamEndpointOverride= in the ConfigMap didn't bother an External cluster deploy. If you want another attempt with the latest master, I can retry. Lmk.
There was a problem hiding this comment.
Let's try the CI job to be safe
|
/test e2e-powervs-capi-ovn |
|
/lgtm |
|
/assign r4f4 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retitle MULTIARCH-5150: Pass IAM endpoint override to PowerVS CloudProviderConfig |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@miyamotoh: This pull request references MULTIARCH-5150 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@miyamotoh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Hiro Miyamoto [email protected]