Add OPENSHIFT_INSTALL_BOOTSTRAP_OS_IMAGE_OVERRIDE env variable...

[kirankt]

Add OPENSHIFT_INSTALL_BOOTSTRAP_OS_IMAGE_OVERRIDE env variable to enable baremetal bootstrap node to work offline
Extend the work of PR: #2061

[openshift-ci-robot]

Hi @kirankt. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcpowermac]

/ok-to-test

[kirankt]

/retest

[stbenjam]

This looks good to me and works the same as the main RHCOS image. Once you're happy with this, could you adjust the commit to match the requirements in https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format?

[stbenjam]

/assign @abhinavdahiya

@abhinavdahiya I know you're trying to avoid additional env variables, but we need to be able to override this unfortunately. This is consistent with the other images, at least.

[kirankt]

/retest

[hardys]

I had some discussion with @abhinavdahiya and it sounds like adding overrides to the install config may be preferred - I added some notes on that to #2597

[hardys]

That said, personally I think this is reasonable, there's already an env var for one bootimage, so this is just making it consistent for both.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kirankt
To complete the pull request process, please assign abhinavdahiya
You can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@kirankt: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack	011bad9	link	/test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7	011bad9	link	/test e2e-aws-scaleup-rhel7
ci/prow/e2e-aws-fips	011bad9	link	/test e2e-aws-fips

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[stbenjam]

Alternative approach after discussing this with installer team: #2757

/close

[openshift-ci-robot]

@stbenjam: Closed this PR.

In response to this:

Alternative approach after discussing this with installer team: #2757

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.