Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1542: Introduce e2e flags for Workload Identity #5363

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

HOSTEDCP-1542: Introduce e2e flags for Workload Identity #5363

wants to merge 2 commits into from
+125 −104

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
This PR contains two commits:

  • the first commit just sorts the e2e flags into platform specific fields and then alphabetically; this was done to make reading through and maintaining those flags easier
  • the second commit adds three flags needed for the Workload Identity; nothing is done with these flags just yet; that will be introduced in a follow on PR

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@bryan-cox
Sort e2e flags by platform
23c3df3 
This commit sorts the e2e flags by platform. Flags that can be used for
any platform are listed first under `Platform-agnostic flags`

Signed-off-by: Bryan Cox <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2025 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

What this PR does / why we need it:
This PR contains two commits:

  • the first commit just sorts the e2e flags into platform specific fields and then alphabetically; this was done to make reading through and maintaining those flags easier
  • the second commit adds three flags needed for the Workload Identity; nothing is done with these flags just yet; that will be introduced in a follow on PR

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area area/testing Indicates the PR includes changes for e2e testing labels Jan 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jan 9, 2025
@bryan-cox
Add additional Azure e2e flags for OIDC
53969b2 
This commit adds three additional Azure e2e flags needed for testing the
OIDC/Workload Identity functionality: OIDC Issuer URL, the filepath to a
 file containing the client IDs of the managed identities associated
with the data plane, and the filepath to the private key for the service
 account token issuer.

Signed-off-by: Bryan Cox <[email protected]>
@bryan-cox bryan-cox force-pushed the HOSTEDCP-1542-add-e2e-flags-only branch from d4ab65e to 53969b2 Compare January 9, 2025 19:40
@bryan-cox bryan-cox marked this pull request as ready for review January 9, 2025 19:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2025
This was referenced Jan 9, 2025
Draft
Open
@Patryk-Stefanski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@bryan-cox
Copy link
Member Author

/test e2e-aws

3 similar comments
@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox
Copy link
Member Author

/test e2e-aws

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e08020b and 2 for PR HEAD 53969b2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2877c7a and 1 for PR HEAD 53969b2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a39bf24 and 0 for PR HEAD 53969b2 in total

@openshift-ci-robot
Copy link

/hold

Revision 53969b2 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2025
@bryan-cox
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2025
@bryan-cox
Copy link
Member Author

/test e2e-aws

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a39bf24 and 2 for PR HEAD 53969b2 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 11, 2025

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 53969b2 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws 53969b2 link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@Patryk-Stefanski Patryk-Stefanski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryan-cox @openshift-ci-robot @Patryk-Stefanski