NO-JIRA: Enforce EnsurePSANotPrivileged for 4.19 and later

[Evan-Reilly]

OpenShiftPodSecurityAdmission feature gate is not enabled by default in 4.18. We need to stop EnsurePSANotPrivileged in 4.18.

https://github.com/openshift/api/blob/release-4.18/features/features.go

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@Evan-Reilly: This pull request explicitly references no jira issue.

In response to this:

OpenShiftPodSecurityAdmission feature gate is not enabled by default in 4.18. We need to stop EnsurePSANotPrivileged in 4.18.

https://github.com/openshift/api/blob/release-4.18/features/features.go

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @Evan-Reilly. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sjenning]

/ok-to-test
/approve

[sjenning]

Bumping openshift/api isn't strictly required for this but we should do it as matter of code maintenance and release level synchronization so 👍

[sjenning]

Looks like bumping k8s beyond what controller-runtime caused a compile time break

# sigs.k8s.io/controller-runtime/pkg/client/fake
vendor/sigs.k8s.io/controller-runtime/pkg/client/fake/client.go:858:29: cannot use c.tracker (variable of type versionedTracker) as "k8s.io/client-go/testing".ObjectTracker value in argument to dryPatch: versionedTracker does not implement "k8s.io/client-go/testing".ObjectTracker (wrong type for method Create)
		have Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string) error
		want Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string, ..."k8s.io/apimachinery/pkg/apis/meta/v1".CreateOptions) error
vendor/sigs.k8s.io/controller-runtime/pkg/client/fake/client.go:[87](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_hypershift/5362/pull-ci-openshift-hypershift-main-images/1877442437773791232#1:build-log.txt%3A87)2:37: cannot use c.tracker (variable of type versionedTracker) as "k8s.io/client-go/testing".ObjectTracker value in argument to testing.ObjectReaction: versionedTracker does not implement "k8s.io/client-go/testing".ObjectTracker (wrong type for method Create)
		have Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string) error
		want Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string, ..."k8s.io/apimachinery/pkg/apis/meta/v1".CreateOptions) error
# sigs.k8s.io/controller-runtime/pkg/webhook/admission
vendor/sigs.k8s.io/controller-runtime/pkg/webhook/admission/webhook.go:158:9: not enough arguments in call to fn
	have (interface{})
	want (context.Context, interface{})
# sigs.k8s.io/controller-runtime/pkg/internal/controller
vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:103:9: not enough arguments in call to fn
	have (interface{})
	want (context.Context, interface{})

We should break this bump out into its own PR since it seems we will need to bump controller-runtime as well. In the meantime, it is not required for this change. Just drop the commit.

[rtheis]

/lgtm
/approved

[rtheis]

/retest-required

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Evan-Reilly, rtheis, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e08020b and 2 for PR HEAD 5d743c3 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e08020b and 2 for PR HEAD 5d743c3 in total

[rtheis]

/retest-required

[rtheis]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2877c7a and 1 for PR HEAD 5d743c3 in total

[rtheis]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a39bf24 and 0 for PR HEAD 5d743c3 in total

[openshift-ci-robot]

/hold

Revision 5d743c3 was retested 3 times: holding

[rtheis]

/retest-required

[rtheis]

/remove-hold

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a39bf24 and 2 for PR HEAD 5d743c3 in total

[rtheis]

/retest-required

[rtheis]

@Evan-Reilly one more test retry then I need you to take a look at the failures.

[openshift-ci]

@Evan-Reilly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws	5d743c3	link	true	/test e2e-aws
ci/prow/e2e-aks	5d743c3	link	true	/test e2e-aks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.