Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Set ownership annotations for TLS artifacts #5355

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Jan 8, 2025

What this PR does / why we need it:

The secrets/configmaps used to store TLS artifacts should have the same annotations as self-hosted version to match TLS registry. See https://github.com/openshift/enhancements/blob/master/enhancements/security/tls-artifacts-registry.md for more infotmation

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release labels Jan 8, 2025
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign muraee for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Member Author

vrutkovs commented Jan 8, 2025

/test e2e-aws

@vrutkovs
Copy link
Member Author

vrutkovs commented Jan 8, 2025

/test e2e-conformance

@vrutkovs vrutkovs marked this pull request as ready for review January 8, 2025 15:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
@vrutkovs vrutkovs changed the title Set ownership annotations for TLS artifacts NO-JIRA: Set ownership annotations for TLS artifacts Jan 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request explicitly references no jira issue.

In response to this:

These secrets/configmaps should have the same annoations as self-hosted version to match TLS registry

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and hasueki January 8, 2025 15:32
@vrutkovs
Copy link
Member Author

vrutkovs commented Jan 8, 2025

/test e2e-conformance

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2025
These secrets/configmaps should have the same annoations as self-hosted version to match TLS registry
@vrutkovs vrutkovs force-pushed the tls-registry-annotations branch from ba417c0 to 03613e2 Compare January 9, 2025 11:55
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2025
@vrutkovs vrutkovs force-pushed the tls-registry-annotations branch from 03613e2 to 7224fd1 Compare January 9, 2025 13:32
@vrutkovs
Copy link
Member Author

vrutkovs commented Jan 9, 2025

/test e2e-aws

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants