-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-1690: KMS Encryption Provider for Etcd Secrets #1682
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Swarup Ghosh <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Swarup Ghosh <[email protected]>
@swghosh: This pull request references API-1690 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @dgrisonnet |
- "@tkashem" | ||
- "@rvanderp" | ||
approvers: | ||
- "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkashem should be the default approver for anything api related as the team lead
You can add either myself or @deads2k for API approvers. But you need one of us. I've already looked at the API so probably me on this occasion.
@tkashem please review this EP and let me know that you're happy conceptually, and then I'll start reviewing from an API perspective
We should only merge the feature gate PR once this has had an initial round of review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add more details on this EP so we can have it ready for the initial round of review.
[TP] Support Kube KMS Integration in OCP (User-Provided)