Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: OpenShift Virtualization Higher Density #1679

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Feature: OpenShift Virtualization Higher Density #1679

wants to merge 17 commits into from

Conversation

iholder101
Copy link

A feature describing OpenShift Virtualization's path to higher density based on:

This is a replacement for #1630.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign coverprice for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

Hi @iholder101. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 17, 2024
@iholder101 iholder101 marked this pull request as ready for review September 17, 2024 11:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@iholder101 iholder101 mentioned this pull request Sep 17, 2024
Closed
@iholder101
Copy link
Author

/cc @enp0s3 @Barakmor1 @fabiand @mrunalp @haircommander @kannon92

haircommander
haircommander reviewed Sep 17, 2024
View reviewed changes
enhancements/kubelet/virtualization-higher-workload-density.md Outdated

#### Timeline

* GA higher workload density in OpenShift Virtualization in 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this timeline still accurate?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe it is.
Please keep me honest @stu-gott.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haircommander Hi, I've checked the Jira planning, we are on track, so yes this is indeed accurate.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haircommander The timeline bullet GA higher workload density in OpenShift Virtualization in 2024 relates to the phase 1 only. Maybe we should add it in brackets

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @haircommander!
@enp0s3 and I reworked the PR. Can you please have another look?

@enp0s3
Copy link

enp0s3 commented Sep 20, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2024
@fabiand @iholder101
feat: OpenShift Virtualization Higher Density
df71f18 
A feature describing CNV's path to higher density based on

- phase 1: wasp
- phase 2: kube swap

Signed-off-by: Itamar Holder <[email protected]>
@fabiand @iholder101
cnv: Swap add more design details
d23c0b8 
Signed-off-by: Itamar Holder <[email protected]>
@fabiand @iholder101
cnv: Drop all xml style comments to make the md linter happy
4307e06 
Signed-off-by: Itamar Holder <[email protected]>
@fabiand @iholder101
cnv: Address Igor's comments
4b42c68 
Signed-off-by: Itamar Holder <[email protected]>
@fabiand @iholder101
cnv: Address Itamar's comments
cf6cc95 
Signed-off-by: Itamar Holder <[email protected]>
@fabiand @iholder101
cnv: Add line breaks
1315f82 
Signed-off-by: Itamar Holder <[email protected]>
@fabiand @iholder101
cnv: fix headers
d444076 
Signed-off-by: Itamar Holder <[email protected]>
@fabiand @iholder101
cnv: Fix table header
1708d57 
Signed-off-by: Itamar Holder <[email protected]>
@fabiand @iholder101
cnv: Mention KSM and FPR
1a7ae77 
Signed-off-by: Itamar Holder <[email protected]>
@fabiand @iholder101
cnv: Add section to make linter happy
36d6745 
Signed-off-by: Itamar Holder <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 25, 2024

@iholder101: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2024
@openshift-bot
Copy link

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@jupierce jupierce Awaiting requested review from jupierce

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

@Barakmor1 Barakmor1 Awaiting requested review from Barakmor1

@enp0s3 enp0s3 Awaiting requested review from enp0s3

@fabiand fabiand Awaiting requested review from fabiand

@kannon92 kannon92 Awaiting requested review from kannon92

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iholder101 @enp0s3 @openshift-bot @haircommander @fabiand