Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor daemon to allow testing platform detection #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor daemon to allow testing platform detection #196

wants to merge 1 commit into from

Conversation

bn222
Copy link
Contributor

@bn222 bn222 commented Oct 25, 2024

No description provided.

@bn222
Copy link
Contributor Author

bn222 commented Oct 25, 2024

PTAL @SalDaniele

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@SalDaniele
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@bn222
Copy link
Contributor Author

bn222 commented Oct 25, 2024

/hold need to think a bit more about naming

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 26, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

/test remaining-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 26, 2024

@bn222: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/make-e2e-test 553e707 link true /test make-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bn222
Copy link
Contributor Author

bn222 commented Oct 27, 2024

/test make-e2e-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrindle vrindle Awaiting requested review from vrindle

@wizhaoredhat wizhaoredhat Awaiting requested review from wizhaoredhat

Assignees

@SalDaniele SalDaniele

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bn222 @SalDaniele @openshift-ci-robot