OCPBUGS-46050: Determine if disabled a11y rules can be re-enabled #14643
Conversation
…ment of the scrollable-region-focusable and aria-roles rules in testa11y config.
openshift-ci-robot
added
the
jira/valid-reference
|
@Mylanos: This pull request references Jira Issue OCPBUGS-46050, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
openshift-ci
bot
added
the
kind/cypress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mylanos The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -65,8 +65,8 @@ Cypress.Commands.add('testA11y', (target: string, selector?: string) => { | |||
| rules: [ | |||
| { id: 'color-contrast', enabled: false }, // seem to be somewhat inaccurate and has difficulty always picking up the correct colors, tons of open issues for it on axe-core | |||
| { id: 'focusable-content', enabled: false }, // recently updated and need to give the PF team time to fix issues before enabling | |||
| { id: 'scrollable-region-focusable', enabled: false }, // recently updated and need to give the PF team time to fix issues before enabling | |||
| { id: 'aria-roles', enabled: false }, // rule is outdated and current installation of axe-core is no longer complaint with newest ariaRoles spec, causing false test failures (specifically with the role='code'). reenable when axe core is updated to at least 4.1.0 | |||
| { id: 'scrollable-region-focusable', enabled: true }, // recently updated and need to give the PF team time to fix issues before enabling | |||
There was a problem hiding this comment.
Once confirmed, I believe deleting these entries will re-enable them.
|
@Mylanos: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
CONSOLE Features and Fixes:
Solution description
testing the enablement of the scrollable-region-focusable and aria-roles rules in testa11y config on CI.Reviewers and assignees:
Additional info:
Screen shots / gifs / design review: