Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-2956: 'create a Project' button on Getting started page doesn't work #14635

Merged
merged 1 commit into from
Jan 8, 2025
Merged

OCPBUGS-2956: 'create a Project' button on Getting started page doesn't work #14635

merged 1 commit into from
Jan 8, 2025

Conversation

lokanandaprabhu
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/OCPBUGS-2956

Analysis / Root cause:
By default the pages will be disabled if user don't have any projects created.

Solution Description:
If user don't have any project and Getting Started section is disabled then Create a Project button will not be shown to user.

Screen shots / Gifs for design review:

----BEFORE---

Screen.Recording.2024-12-18.at.12.49.03.PM.mov

---AFTER----

Screen.Recording.2024-12-18.at.12.49.35.PM.mov

Unit test coverage report:
NA

Test setup:

  1. A new normal user login to OCP web console, user will be redirected to Getting Started page
  2. try to create a project via 'create a Project' button in message "Select a Project to start adding to it or create a Project."

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-2956, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-2956

Analysis / Root cause:
By default the pages will be disabled if user don't have any projects created.

Solution Description:
If user don't have any project and Getting Started section is disabled then Create a Project button will not be shown to user.

Screen shots / Gifs for design review:

----BEFORE---

Screen.Recording.2024-12-18.at.12.49.03.PM.mov

---AFTER----

Screen.Recording.2024-12-18.at.12.49.35.PM.mov

Unit test coverage report:
NA

Test setup:

  1. A new normal user login to OCP web console, user will be redirected to Getting Started page
  2. try to create a project via 'create a Project' button in message "Select a Project to start adding to it or create a Project."

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 18, 2024
vikram-raj
vikram-raj approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vikram-raj
Copy link
Member

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Jira Issue OCPBUGS-2956, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a9ac994 and 2 for PR HEAD e734ace in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD aaefe15 and 1 for PR HEAD e734ace in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 873ced9 and 0 for PR HEAD e734ace in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8085aa6 and 2 for PR HEAD e734ace in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 06115eb and 1 for PR HEAD e734ace in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 92d8251 into openshift:master Jan 8, 2025
7 checks passed
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: Jira Issue OCPBUGS-2956: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2956 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-2956

Analysis / Root cause:
By default the pages will be disabled if user don't have any projects created.

Solution Description:
If user don't have any project and Getting Started section is disabled then Create a Project button will not be shown to user.

Screen shots / Gifs for design review:

----BEFORE---

Screen.Recording.2024-12-18.at.12.49.03.PM.mov

---AFTER----

Screen.Recording.2024-12-18.at.12.49.35.PM.mov

Unit test coverage report:
NA

Test setup:

  1. A new normal user login to OCP web console, user will be redirected to Getting Started page
  2. try to create a project via 'create a Project' button in message "Select a Project to start adding to it or create a Project."

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202501081511.p0.g92d8251.assembly.stream.el9.
All builds following this will include this PR.

@lokanandaprabhu
Copy link
Contributor Author

/cherrypick release-4.18

@openshift-cherrypick-robot
Copy link

@lokanandaprabhu: new pull request created: #14672

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj approved these changes

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@Lucifergene Lucifergene Awaiting requested review from Lucifergene

Assignees

@vikram-raj vikram-raj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lokanandaprabhu @openshift-ci-robot @vikram-raj @openshift-bot @openshift-cherrypick-robot