Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-4077: Refactor BasicAuthSubform to be functional component #14631

Conversation

Mylanos
Copy link
Contributor

@Mylanos Mylanos commented Dec 17, 2024

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Test cases:

Additional info:

Screen shots / gifs / design review:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2024

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:
Refactors BasicAuthSubform to be a functional component
Solution description
Reviewers and assignees:
Additional info:
To follow the order of tickets in the Secret forms tech debt, this should get merged after CONSOLE-4076
Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kyoto and rhamilto December 17, 2024 13:21
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Dec 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2024

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Additional info:

To follow the order of tickets in the Secret forms tech debt, this should get merged after []([CONSOLE-4076](https://issues.redhat.com/browse/CONSOLE-4076))

Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2024

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Additional info:

To follow the order of tickets in the Secret forms tech debt, this should get merged after [CONSOLE-4076](https://issues.redhat.com/browse/CONSOLE-4076)

Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2024

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Additional info:

To follow the order of tickets in the Secret forms tech debt, this should get merged after [CONSOLE-4076](https://issues.redhat.com//browse/CONSOLE-4076)

Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Mylanos
Copy link
Contributor Author

Mylanos commented Dec 18, 2024

/retest

@Mylanos Mylanos closed this Dec 18, 2024
@Mylanos Mylanos reopened this Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2024

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Additional info:

To follow the order of tickets in the Secret forms tech debt, this should get merged after [CONSOLE-4076](https://issues.redhat.com//browse/CONSOLE-4076)

Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Mylanos
Copy link
Contributor Author

Mylanos commented Dec 19, 2024

/retest

3 similar comments
@Mylanos
Copy link
Contributor Author

Mylanos commented Dec 19, 2024

/retest

@Mylanos
Copy link
Contributor Author

Mylanos commented Dec 20, 2024

/retest

@Mylanos
Copy link
Contributor Author

Mylanos commented Dec 20, 2024

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 2, 2025

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Additional info:

To follow the order of tickets in the Secret forms tech debt, this should get merged after https://issues.redhat.com//browse/CONSOLE-4076

Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 2, 2025

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Additional info:

To follow the order of tickets in the Secret forms tech debt, this should get merged after [j](https://issues.redhat.com//browse/CONSOLE-4076)

Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 2, 2025

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Test cases:

Additional info:

To follow the order of tickets in the Secret forms tech debt, this should get merged after [CONSOLE-4076](https://issues.redhat.com//browse/CONSOLE-4076).

Screen shots / gifs / design review:

[j](https://issues.redhat.com//browse/CONSOLE-4076)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 2, 2025

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Test cases:

Additional info:

To follow the order of tickets in the Secret forms tech debt, this should get merged after https://issues.redhat.com//browse/CONSOLE-4076.

Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 2, 2025

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Test cases:

Additional info:

To follow the order of tickets in the Secret forms tech debt epic, this should get merged after https://issues.redhat.com//browse/CONSOLE-4076.

Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Mylanos, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2025

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Test cases:

Additional info:

Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Mylanos
Copy link
Contributor Author

Mylanos commented Jan 6, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 6, 2025
@Mylanos
Copy link
Contributor Author

Mylanos commented Jan 6, 2025

This is a tech debt, so I'm adding
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jan 6, 2025
@Mylanos
Copy link
Contributor Author

Mylanos commented Jan 7, 2025

QE Approver
/assign @yapei

@yapei
Copy link
Contributor

yapei commented Jan 8, 2025

tested Basic authentication type secret creation, edits and delete, pesudo translation
no issues found
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2025

@Mylanos: This pull request references CONSOLE-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

Refactors BasicAuthSubform to be a functional component

Solution description

Reviewers and assignees:

Test cases:

Additional info:

Screen shots / gifs / design review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 10c0bd8 and 2 for PR HEAD ee8c81c in total

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

@Mylanos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e4649ad into openshift:master Jan 9, 2025
7 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202501090738.p0.ge4649ad.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants