Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43794: add ability to control kube rbac proxy container image on controlplane #529

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

OCPBUGS-43794: add ability to control kube rbac proxy container image on controlplane #529

wants to merge 1 commit into from
+17 −0

Conversation

Patryk-Stefanski
Copy link
Contributor

@Patryk-Stefanski Patryk-Stefanski commented Oct 24, 2024 •
edited
Loading

@Patryk-Stefanski
OCPBUGS-41365: add ability to control kube rbac proxy container image…
e8b66d6 
… on controlplane

OCPBUGS-41365: fix typo CONTROL_PLANE_KUBE_RBAC_PROXY_IMAGE -> KUBE_RBAC_PROXY_CONTROL_PLANE_IMAGE

OCPBUGS-41365: add KUBE_RBAC_PROXY_CONTROL_PLANE_IMAGE to other needed deployments
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 24, 2024
@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-43794, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @fxierh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 24, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2024
@Patryk-Stefanski Patryk-Stefanski changed the base branch from master to release-4.17 October 24, 2024 13:03
@openshift-ci openshift-ci bot requested a review from fxierh October 24, 2024 13:03
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 24, 2024
@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-43794, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.18.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-43794 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Patryk-Stefanski
Once this PR has been reviewed and has the lgtm label, please assign tsmetana for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-43794, which is invalid:

  • expected Jira Issue OCPBUGS-43794 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is a manual cherry-pick of:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024 •
edited
Loading

@Patryk-Stefanski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-deps e8b66d6 link true /test verify-deps
ci/prow/e2e-azure-csi e8b66d6 link true /test e2e-azure-csi
ci/prow/hypershift-aws-e2e-external e8b66d6 link true /test hypershift-aws-e2e-external
ci/prow/security e8b66d6 link false /test security
ci/prow/verify e8b66d6 link true /test verify
ci/prow/e2e-gcp-manual-oidc e8b66d6 link false /test e2e-gcp-manual-oidc
ci/prow/e2e-aws-ovn-upgrade e8b66d6 link true /test e2e-aws-ovn-upgrade
ci/prow/images e8b66d6 link true /test images
ci/prow/unit e8b66d6 link true /test unit
ci/prow/e2e-azure-file-csi e8b66d6 link true /test e2e-azure-file-csi
ci/prow/verify-kustomize-assets e8b66d6 link true /test verify-kustomize-assets

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2024
@gnufied
Copy link
Member

gnufied commented Oct 28, 2024

/retest

@Patryk-Stefanski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-43794, which is invalid:

  • expected Jira Issue OCPBUGS-43794 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Patryk-Stefanski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 4, 2024
@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-43794, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-41365 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-41365 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @fxierh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Patryk-Stefanski Patryk-Stefanski mentioned this pull request Nov 4, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxierh fxierh Awaiting requested review from fxierh

@dobsonj dobsonj Awaiting requested review from dobsonj

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees
No one assigned
Labels
jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Patryk-Stefanski @openshift-ci-robot @gnufied @openshift-merge-robot