Merge pull request #532 from shiftstack/remove-redundant-roles

NO-JIRA: Remove redundant clusterrole rules
openshift · Oct 30, 2024 · 6390211 · 6390211
2 parents aa574fc + 18b5916
commit 6390211
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 117 deletions.
diff --git a/assets/csidriveroperators/aws-ebs/base/05_clusterrole.yaml b/assets/csidriveroperators/aws-ebs/base/05_clusterrole.yaml
@@ -280,21 +280,8 @@ rules:
   - watch
 # Allow kube-rbac-proxy to create TokenReview to be able to authenticate Prometheus when collecting metrics
 - apiGroups:
-  - "authentication.k8s.io"
+  - authentication.k8s.io
   resources:
-  - "tokenreviews"
+  - tokenreviews
   verbs:
-  - "create"
-- apiGroups:
-  - coordination.k8s.io
-  resources:
-  - leases
-  verbs:
-  - get
-  - list
-  - watch
   - create
-  - update
-  - patch
-  - delete
-
diff --git a/...ted/rbac.authorization.k8s.io_v1_clusterrole_aws-ebs-csi-driver-operator-clusterrole.yaml b/...ted/rbac.authorization.k8s.io_v1_clusterrole_aws-ebs-csi-driver-operator-clusterrole.yaml
@@ -283,15 +283,3 @@ rules:
   - tokenreviews
   verbs:
   - create
-- apiGroups:
-  - coordination.k8s.io
-  resources:
-  - leases
-  verbs:
-  - get
-  - list
-  - watch
-  - create
-  - update
-  - patch
-  - delete
diff --git a/...ted/rbac.authorization.k8s.io_v1_clusterrole_aws-ebs-csi-driver-operator-clusterrole.yaml b/...ted/rbac.authorization.k8s.io_v1_clusterrole_aws-ebs-csi-driver-operator-clusterrole.yaml
@@ -283,15 +283,3 @@ rules:
   - tokenreviews
   verbs:
   - create
-- apiGroups:
-  - coordination.k8s.io
-  resources:
-  - leases
-  verbs:
-  - get
-  - list
-  - watch
-  - create
-  - update
-  - patch
-  - delete
diff --git a/assets/csidriveroperators/azure-disk/base/06_clusterrole.yaml b/assets/csidriveroperators/azure-disk/base/06_clusterrole.yaml
@@ -94,18 +94,6 @@ rules:
   - create
   - watch
   - delete
-- apiGroups:
-  - coordination.k8s.io
-  resources:
-  - leases
-  verbs:
-  - get
-  - list
-  - watch
-  - create
-  - update
-  - patch
-  - delete
 - apiGroups:
   - ''
   resources:
@@ -302,8 +290,8 @@ rules:
   - watch
 # Allow kube-rbac-proxy to create TokenReview to be able to authenticate Prometheus when collecting metrics
 - apiGroups:
-  - "authentication.k8s.io"
+  - authentication.k8s.io
   resources:
-  - "tokenreviews"
+  - tokenreviews
   verbs:
-  - "create"
+  - create
diff --git a/.../rbac.authorization.k8s.io_v1_clusterrole_azure-disk-csi-driver-operator-clusterrole.yaml b/.../rbac.authorization.k8s.io_v1_clusterrole_azure-disk-csi-driver-operator-clusterrole.yaml
@@ -93,18 +93,6 @@ rules:
   - create
   - watch
   - delete
-- apiGroups:
-  - coordination.k8s.io
-  resources:
-  - leases
-  verbs:
-  - get
-  - list
-  - watch
-  - create
-  - update
-  - patch
-  - delete
 - apiGroups:
   - ""
   resources:

diff --git a/.../rbac.authorization.k8s.io_v1_clusterrole_azure-disk-csi-driver-operator-clusterrole.yaml b/.../rbac.authorization.k8s.io_v1_clusterrole_azure-disk-csi-driver-operator-clusterrole.yaml
@@ -93,18 +93,6 @@ rules:
   - create
   - watch
   - delete
-- apiGroups:
-  - coordination.k8s.io
-  resources:
-  - leases
-  verbs:
-  - get
-  - list
-  - watch
-  - create
-  - update
-  - patch
-  - delete
 - apiGroups:
   - ""
   resources:

diff --git a/assets/csidriveroperators/azure-file/base/06_clusterrole.yaml b/assets/csidriveroperators/azure-file/base/06_clusterrole.yaml
@@ -94,18 +94,6 @@ rules:
   - create
   - watch
   - delete
-- apiGroups:
-  - coordination.k8s.io
-  resources:
-  - leases
-  verbs:
-  - get
-  - list
-  - watch
-  - create
-  - update
-  - patch
-  - delete
 - apiGroups:
   - ''
   resources:
@@ -306,8 +294,8 @@ rules:
   - watch
 # Allow kube-rbac-proxy to create TokenReview to be able to authenticate Prometheus when collecting metrics
 - apiGroups:
-  - "authentication.k8s.io"
+  - authentication.k8s.io
   resources:
-  - "tokenreviews"
+  - tokenreviews
   verbs:
-  - "create"
+  - create
diff --git a/.../rbac.authorization.k8s.io_v1_clusterrole_azure-file-csi-driver-operator-clusterrole.yaml b/.../rbac.authorization.k8s.io_v1_clusterrole_azure-file-csi-driver-operator-clusterrole.yaml
@@ -93,18 +93,6 @@ rules:
   - create
   - watch
   - delete
-- apiGroups:
-  - coordination.k8s.io
-  resources:
-  - leases
-  verbs:
-  - get
-  - list
-  - watch
-  - create
-  - update
-  - patch
-  - delete
 - apiGroups:
   - ""
   resources:

diff --git a/.../rbac.authorization.k8s.io_v1_clusterrole_azure-file-csi-driver-operator-clusterrole.yaml b/.../rbac.authorization.k8s.io_v1_clusterrole_azure-file-csi-driver-operator-clusterrole.yaml
@@ -93,18 +93,6 @@ rules:
   - create
   - watch
   - delete
-- apiGroups:
-  - coordination.k8s.io
-  resources:
-  - leases
-  verbs:
-  - get
-  - list
-  - watch
-  - create
-  - update
-  - patch
-  - delete
 - apiGroups:
   - ""
   resources: