Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43412: bump update k8s.io/* dependencies to v1.31.1 & openshift/api #1156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EmilienM
Copy link
Member

@EmilienM EmilienM commented Oct 15, 2024

  • Update go.mod with k8s.io/* dependencies to v1.31.1 & openshift/api to a recent commit in order to bring the new floatingIP field for platform OpenStack
  • make update test verify
  • controller: adjustments for new control-runtime & ratelimit

Note: these commits have to be squashed together, in order to pass CI.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2024
@openshift-ci-robot
Copy link
Contributor

@EmilienM: This pull request explicitly references no jira issue.

In response to this:

  • vendoring: update k8s.io/ dependencies to v1.31.1 & openshift/api*
  • make update
  • controller: adjustments for new control-runtime & ratelimit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign candita for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM
Copy link
Member Author

/test e2e-azure-ovn

@Miciah
Copy link
Contributor

Miciah commented Oct 16, 2024

Thanks! Would you mind doing the following?

  • Squash the commits so that make test verify will succeed for every commit in the history.
  • Add a reference to https://issues.redhat.com/browse/OCPBUGS-43412 in the commit message, and add OCPBUGS-43412: to the PR title.
  • Document the commands that you used in order to do the bump in the commit message.

For an example commit message from another k8s.io/* and controller-runtime vendor bump, see openshift/cluster-dns-operator@dee78ad.

@Miciah
Copy link
Contributor

Miciah commented Oct 16, 2024

I'm guessing that the openshift/api and k8s.io/* bumps cannot be done in separate PRs. Could you mention that in the commit message, and mention that the openshift/api bump brings in the new floatingip field?

@EmilienM EmilienM changed the title NO-JIRA: bump update k8s.io/* dependencies to v1.31.1 & openshift/api OCPBUGS-43412: bump update k8s.io/* dependencies to v1.31.1 & openshift/api Oct 16, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 16, 2024
@openshift-ci-robot
Copy link
Contributor

@EmilienM: This pull request references Jira Issue OCPBUGS-43412, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • vendoring: update k8s.io/* dependencies to v1.31.1 & openshift/api
  • make update
  • controller: adjustments for new control-runtime & ratelimit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan October 16, 2024 12:09
@openshift-ci-robot
Copy link
Contributor

@EmilienM: This pull request references Jira Issue OCPBUGS-43412, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

  • vendoring: update k8s.io/* dependencies to v1.31.1 & openshift/api
  • make update test verify
  • controller: adjustments for new control-runtime & ratelimit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Miciah
Copy link
Contributor

Miciah commented Oct 16, 2024

/assign

@EmilienM
Copy link
Member Author

/test e2e-aws-operator-techpreview

Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants