-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Allow setting router image in hack/release-local.sh #1088
base: master
Are you sure you want to change the base?
Conversation
The default router image in the ingress operator deployment manifest is not up to date, and sometimes causes red herring issues when debugging changes. With this change, a user can set the IMAGE environment variable to a router image pullspec, and hack/release-local.sh will update the deployment manifest to use the specified image. Alternatively, a user can set the GET_IMAGE environment variable to a non-empty value, and hack/release-local.sh will query the cluster in the user's default kubeconfig to automatically get the router image currently in use and use the same image in its generated manifests. Note that GET_IMAGE requires read access to the openshift-ingress-operator/ingress-operator deployment.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rfredette: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
The default router image in the ingress operator deployment manifest is not up to date, and sometimes causes red herring issues when debugging changes.
With this change, a user can set the
IMAGE
environment variable to a router image pullspec, and hack/release-local.sh will update the deployment manifest to use the specified image.Alternatively, a user can set the
GET_IMAGE
environment variable to a non-empty value, and hack/release-local.sh will query the cluster in the user's default kubeconfig to automatically get the router image currently in use and use the same image in its generated manifests. Note thatGET_IMAGE
requires read access to theopenshift-ingress-operator/ingress-operator
deployment.