Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.10][SRVKS-987] Fix deprecated fields #96

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #95

/assign nak3

@openshift-ci openshift-ci bot requested review from alanfx and rhuss August 15, 2023 06:13
@nak3 nak3 changed the title [release-v1.10] [release-v1.9][SRVKS-987] Fix deprecated fields [release-v1.10][SRVKS-987] Fix deprecated fields Aug 15, 2023
@nak3
Copy link

nak3 commented Aug 15, 2023

/lgtm
/approve
/cherry-pick release-v1.11

@openshift-cherrypick-robot
Copy link
Author

@nak3: once the present PR merges, I will cherry-pick it on top of release-v1.11 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick release-v1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm label Aug 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #96 (c8fac86) into release-v1.10 (915d5f8) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff               @@
##           release-v1.10      #96   +/-   ##
==============================================
  Coverage          80.78%   80.78%           
==============================================
  Files                 18       18           
  Lines               1343     1343           
==============================================
  Hits                1085     1085           
  Misses               205      205           
  Partials              53       53           
Files Changed Coverage Δ
pkg/envoy/api/headers.go 100.00% <100.00%> (ø)

@nak3 nak3 merged commit 7235ec5 into openshift-knative:release-v1.10 Aug 15, 2023
17 of 18 checks passed
@openshift-cherrypick-robot
Copy link
Author

@nak3: new pull request created: #97

In response to this:

/lgtm
/approve
/cherry-pick release-v1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants