[release-v1.10] Sync upstream release #110
knative-verify.yaml
on: pull_request
verify
/
Verify Deps and Codegen
3m 0s
Annotations
2 errors and 1 warning
verify / Verify Deps and Codegen:
vendor/knative.dev/pkg/environment/client_config.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/vendor/knative.dev/pkg/environment/client_config.go b/vendor/knative.dev/pkg/environment/client_config.go
index aef3392..04d4220 100644
--- a/vendor/knative.dev/pkg/environment/client_config.go
+++ b/vendor/knative.dev/pkg/environment/client_config.go
@@ -19,10 +19,8 @@ package environment
import (
"flag"
"fmt"
- "log"
"math"
"os"
- "strconv"
"k8s.io/client-go/rest"
"k8s.io/client-go/tools/clientcmd"
@@ -47,19 +45,9 @@ func (c *ClientConfig) InitFlags(fs *flag.FlagSet) {
fs.StringVar(&c.Kubeconfig, "kubeconfig", os.Getenv("KUBECONFIG"),
"Path to a kubeconfig. Only required if out-of-cluster.")
- fs.IntVar(&c.Burst, "kube-api-burst", int(envVarOrDefault("KUBE_API_BURST", 0)), "Maximum burst for throttle.")
+ fs.IntVar(&c.Burst, "kube-api-burst", 0, "Maximum burst for throttle.")
- fs.Float64Var(&c.QPS, "kube-api-qps", envVarOrDefault("KUBE_API_QPS", 0.0), "Maximum QPS to the server from the client.")
-}
-
-func envVarOrDefault(key string, val float64) float64 {
- var err error
- if v := os.Getenv(key); v != "" {
- if val, err = strconv.ParseFloat(v, 64); err != nil {
- log.Fatal(err)
- }
- }
- return val
+ fs.Float64Var(&c.QPS, "kube-api-qps", 0, "Maximum QPS to the server from the client.")
}
func (c *ClientConfig) GetRESTConfig() (*rest.Config, error) {
|
verify / Verify Deps and Codegen
Process completed with exit code 1.
|
verify / Verify Deps and Codegen
Restore cache failed: Dependencies file is not found in /home/runner/work/net-kourier/net-kourier. Supported file pattern: go.sum
|