-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRVCLI-401: 💝 Donate deviate tool #155
base: main
Are you sure you want to change the base?
Conversation
/kind enhancement |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d1cae9f
to
a98c88c
Compare
@cardil: This pull request references SRVCLI-401 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@cardil: This pull request references SRVCLI-401 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Would it make sense to make it a submodule isolate related |
Yes, I was thinking the same. My initial idea was to change the repo's layout to mirror the https://github.com/knative/toolbox (and rename the repo as well). But, the team was reluctant to rename because of short terms breakages. The same applies to any re-layout. Personally, I would go for it, as the breakages aren't a big problem here, and could be quickly fixed. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Donating the deviate tool from https://github.com/cardil/deviate
Related to SRVCLI-401