Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the HTTPS proxy notification tooltip #2686

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

liatb-rh
Copy link
Contributor

Updating the translation of HTTPS tooltip

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
Copy link

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liatb-rh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2024
@jgyselov
Copy link
Collaborator

Hi @liatb-rh, this repo requires all commits to be signed with a GPG key, otherwise we cannot merge to master.

You can also let us know and we can commit these changes ourselves.

@liatb-rh liatb-rh marked this pull request as ready for review November 3, 2024 12:11
@liatb-rh liatb-rh requested a review from a team as a code owner November 3, 2024 12:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2024
@liatb-rh
Copy link
Contributor Author

liatb-rh commented Nov 3, 2024

Hey @ammont82 , fixed the unverified commit. thanks

Related to https://issues.redhat.com/browse/MGMT-19050
Changed the translation of https tooltip text
image

@ammont82 ammont82 added this to the v2.36 milestone Nov 4, 2024
@ammont82 ammont82 added the OCM label Nov 4, 2024
@ammont82 ammont82 merged commit be5946f into openshift-assisted:master Nov 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCM size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants