Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow skipping hot reload dn validation (#4752)" #4840

Closed

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 24, 2024

This reverts commit c8cacf1.

Description

This PR reverts #4752 on the main branch. Reverting this PR for now because it has conflicts with #4671 and needs to be adapted to the SSL refactor.

Currently, the main branch has failing CI so reverting this PR will ensure we can merge other PRs.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.87%. Comparing base (eb7f821) to head (fecbf34).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ensearch/security/ssl/DefaultSecurityKeyStore.java 20.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4840      +/-   ##
==========================================
+ Coverage   69.82%   69.87%   +0.05%     
==========================================
  Files         320      320              
  Lines       21661    21661              
  Branches     3456     3456              
==========================================
+ Hits        15124    15136      +12     
+ Misses       4742     4737       -5     
+ Partials     1795     1788       -7     
Files with missing lines Coverage Δ
...arch/security/ssl/OpenSearchSecuritySSLPlugin.java 87.02% <ø> (ø)
...ensearch/security/ssl/util/SSLConfigConstants.java 79.16% <ø> (ø)
...ensearch/security/ssl/DefaultSecurityKeyStore.java 26.48% <20.00%> (ø)

... and 9 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant