-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove snapshot_spec and duplicate commands #450
feat: remove snapshot_spec and duplicate commands #450
Conversation
Signed-off-by: suzhou <[email protected]>
19b6f29
to
d93975b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still needed to delete more than these for this to work.
One function might also be causing conflicts or it's improperly defined.
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
The root cause is that IM plugin add a commands named |
Add result log of the PR: IM logs
|
According to the log above, the |
@SuZhou-Joe linting has issue it seems like. |
Yeah just checked by removing the |
Yeah seems like multiple files (not just the IM plugin tests having linting issues). Do you mind cleaning them up here? |
Will some of the changes from the original PR and this PR make it into the main branch as well? |
I think this feature is only in 2.x branch right now, if I remember correctly as they start developing on 2.x not main, correct me if I am mistaken here. Thanks. |
The lint checking seemed to be caused by SR plugin, not IM, seems in a previous PR didnt clean up. |
I think @SuZhou-Joe mentioned yesterday that he removed the snapshot test. |
* feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]> (cherry picked from commit 900c8b0)
Related to opensearch-project/opensearch-build#2908 |
* feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]> (cherry picked from commit 900c8b0) Co-authored-by: suzhou <[email protected]>
…#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]>
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove some useless test case Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec and duplicate commands (#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]> * feat: lint Signed-off-by: suzhou <[email protected]> * feat: fix workflow bug Signed-off-by: suzhou <[email protected]> * feat: use 2.5.0 version Signed-off-by: suzhou <[email protected]> * feat: revert version to 3.0.0 Signed-off-by: suzhou <[email protected]> --------- Signed-off-by: suzhou <[email protected]>
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove some useless test case Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec and duplicate commands (opensearch-project#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]> * feat: lint Signed-off-by: suzhou <[email protected]> * feat: fix workflow bug Signed-off-by: suzhou <[email protected]> * feat: use 2.5.0 version Signed-off-by: suzhou <[email protected]> * feat: revert version to 3.0.0 Signed-off-by: suzhou <[email protected]> --------- Signed-off-by: suzhou <[email protected]> (cherry picked from commit 95edebc)
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove some useless test case Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec and duplicate commands (opensearch-project#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]> * feat: lint Signed-off-by: suzhou <[email protected]> * feat: fix workflow bug Signed-off-by: suzhou <[email protected]> * feat: use 2.5.0 version Signed-off-by: suzhou <[email protected]> * feat: revert version to 3.0.0 Signed-off-by: suzhou <[email protected]> --------- Signed-off-by: suzhou <[email protected]> (cherry picked from commit 95edebc)
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove some useless test case Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec and duplicate commands (#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]> * feat: lint Signed-off-by: suzhou <[email protected]> * feat: fix workflow bug Signed-off-by: suzhou <[email protected]> * feat: use 2.5.0 version Signed-off-by: suzhou <[email protected]> * feat: revert version to 3.0.0 Signed-off-by: suzhou <[email protected]> --------- Signed-off-by: suzhou <[email protected]> (cherry picked from commit 95edebc)
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove some useless test case Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec and duplicate commands (#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]> * feat: lint Signed-off-by: suzhou <[email protected]> * feat: fix workflow bug Signed-off-by: suzhou <[email protected]> * feat: use 2.5.0 version Signed-off-by: suzhou <[email protected]> * feat: revert version to 3.0.0 Signed-off-by: suzhou <[email protected]> --------- Signed-off-by: suzhou <[email protected]> (cherry picked from commit 95edebc)
…#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]>
…-project#450)" This reverts commit a797af9.
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove some useless test case Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec and duplicate commands (opensearch-project#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]> * feat: lint Signed-off-by: suzhou <[email protected]> * feat: fix workflow bug Signed-off-by: suzhou <[email protected]> * feat: use 2.5.0 version Signed-off-by: suzhou <[email protected]> * feat: revert version to 3.0.0 Signed-off-by: suzhou <[email protected]> --------- Signed-off-by: suzhou <[email protected]> Signed-off-by: Jakub Przybylski <[email protected]>
…#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]> Signed-off-by: [email protected] <[email protected]>
…earch-project#536) * feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove duplicate commands Signed-off-by: suzhou <[email protected]> * feat: remove some useless test case Signed-off-by: suzhou <[email protected]> * feat: remove snapshot_spec and duplicate commands (opensearch-project#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <[email protected]> * feat: make actions to run again Signed-off-by: suzhou <[email protected]> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <[email protected]> Signed-off-by: suzhou <[email protected]> * feat: lint Signed-off-by: suzhou <[email protected]> * feat: fix workflow bug Signed-off-by: suzhou <[email protected]> * feat: use 2.5.0 version Signed-off-by: suzhou <[email protected]> * feat: revert version to 3.0.0 Signed-off-by: suzhou <[email protected]> --------- Signed-off-by: suzhou <[email protected]> (cherry picked from commit 95edebc) Signed-off-by: [email protected] <[email protected]>
Signed-off-by: suzhou [email protected]
Description
The snapshot spec is no long needed in IM plugin and blocked the E2E test in this repo.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.