Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit comment for minimum_master_nodes config #4316

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

10000-ki
Copy link

@10000-ki 10000-ki commented Jan 2, 2024

Description

https://github.com/opensearch-project/OpenSearch/blob/6a01d2f95b7e98c601949a58b92b91e3e4022e17/buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchCluster.java#L410

discovery.zen.minimum_master_nodes is only valid for opensearch 1.x.x
I think it could confuse the user, so I improved the comment.

Issues Resolved

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11f9ea4) 91.18% compared to head (cf1d7df) 91.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4316   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files         189      189           
  Lines        6146     6146           
=======================================
  Hits         5604     5604           
  Misses        542      542           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prudhvigodithi
Copy link
Member

LGTM, adding @peterzhuamazon @gaiksaya
Thank you

@10000-ki
Copy link
Author

@peterzhuamazon hi!
can you check this pr??

@peterzhuamazon
Copy link
Member

Thanks for opening the PR @10000-ki but I am a bit confused here:

I think that check is only to see if (node.getVersion().onOrAfter("7.0.0")), not related to 1.x or 2.x as the change related to that is:

https://github.com/opensearch-project/OpenSearch/blob/6532caa203955e2ca55cc6f241365b0734d040f3/buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchCluster.java#L399-L402

Thanks.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for now as it needs some clarifications.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants