-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit comment for minimum_master_nodes config #4316
base: main
Are you sure you want to change the base?
edit comment for minimum_master_nodes config #4316
Conversation
Signed-off-by: 10000-ki <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4316 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 189 189
Lines 6146 6146
=======================================
Hits 5604 5604
Misses 542 542 ☔ View full report in Codecov by Sentry. |
LGTM, adding @peterzhuamazon @gaiksaya |
@peterzhuamazon hi! |
Thanks for opening the PR @10000-ki but I am a bit confused here: I think that check is only to see if (node.getVersion().onOrAfter("7.0.0")), not related to 1.x or 2.x as the change related to that is: Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking for now as it needs some clarifications.
Thanks.
Description
https://github.com/opensearch-project/OpenSearch/blob/6a01d2f95b7e98c601949a58b92b91e3e4022e17/buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchCluster.java#L410
discovery.zen.minimum_master_nodes
is only valid for opensearch 1.x.xI think it could confuse the user, so I improved the comment.
Issues Resolved
None
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.