Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central workflow to trigger pre-release workflows #4280

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

prudhvigodithi
Copy link
Collaborator

Description

Part of pre-release actives, a central workflow that triggers all the pre-release workflows.

Issues Resolved

#4136 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a13aa1c) 91.26% compared to head (5bb69e6) 91.18%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4280      +/-   ##
==========================================
- Coverage   91.26%   91.18%   -0.09%     
==========================================
  Files         189      189              
  Lines        6124     6146      +22     
==========================================
+ Hits         5589     5604      +15     
- Misses        535      542       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prudhvigodithi
Copy link
Collaborator Author

prudhvigodithi commented Dec 12, 2023

Some high level details.

  • Basic approach to trigger all the jobs in order.
  • Uses wait: true, waits until the job is completed, we can change to false once we are confident to ensure not to wait for job status.
  • Can be improved in 2nd iteration to optimize the code to run based out of lists like [OS, OSD], [tar, deb, rpm, windows, apt, yum].

@prudhvigodithi
Copy link
Collaborator Author

prudhvigodithi commented Dec 21, 2023

FYI, Found that the Jenkins tests has a bug handling build step which returns parameters=[null, null, null, null], but the actual logic to invoke the build works with right parameters passed.

Seen this in past PR as well.
opensearch-project/opensearch-build-libraries@35267f6#diff-2691a2da3434bcea33ddddd273112adeddd1b30dfa84b8837ca556a509a0b668

I have raised a comment in JenkinsPipelineUnit repo regarding this jenkinsci/JenkinsPipelineUnit#551 (comment)

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor nits with naming. I would suggest to replace all echo statements with actually artifact promotion statments. For example, as an external user I don't know what promote-repos jobs does. So echo statement at the end of execution can help them understand, yum repo for opensearch-2.12.0 is release successfully.

jenkins/promotion/release-promotion.jenkinsfile Outdated Show resolved Hide resolved
jenkins/promotion/release-promotion.jenkinsfile Outdated Show resolved Hide resolved
jenkins/promotion/release-promotion.jenkinsfile Outdated Show resolved Hide resolved
jenkins/promotion/release-promotion.jenkinsfile Outdated Show resolved Hide resolved
jenkins/promotion/release-promotion.jenkinsfile Outdated Show resolved Hide resolved
jenkins/promotion/release-promotion.jenkinsfile Outdated Show resolved Hide resolved
@prudhvigodithi
Copy link
Collaborator Author

Hey @gaiksaya I have updated all your NIT's in my latest commit, coming back with your suggestion to update the echo statement as yum repo for opensearch-2.12.0 is release successfully, the idea here is we are running the release promotion as part of the pre-release activities and should be triggered by the release-manager, so the right way to know is if the child promotion job is successfully completed for not and not to ensure the distribution is released successfully, I have added updated the echo statements as example Promotion successful for Debian Apt OpenSearch!, let me know WDYT.
Thanks

Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi prudhvigodithi merged commit 6eecb4a into opensearch-project:main Dec 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants