Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all the shell scripts to the scripts folder #4099

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vchrombie
Copy link

Description

This PR movies all the shell scripts to the scripts folder. It also updates the tests and documentation to include the new path of the shell scripts.

Issues Resolved

Closes #2495

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This commit also updates the tests and documentation to
include the new path of the shell scripts.

Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #4099 (4e2c1b8) into main (777bfc9) will not change coverage.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4099   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files         187      187           
  Lines        5730     5730           
=======================================
  Hits         5343     5343           
  Misses        387      387           
Files Coverage Δ
src/report_workflow/test_report_runner.py 98.86% <100.00%> (ø)
src/validation_workflow/validation_args.py 100.00% <ø> (ø)

@vchrombie
Copy link
Author

Some of the python and groovy tests failed, so I am trying to fix them.

Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
@vchrombie vchrombie force-pushed the 2495-move-sh-scripts branch from 91e3485 to 4e2c1b8 Compare October 3, 2023 20:18
@vchrombie
Copy link
Author

All the tests should pass now. 🚀

@vchrombie
Copy link
Author

Let me know if you want me to squash the commits.

@vchrombie
Copy link
Author

@gaiksaya @peterzhuamazon
Do you mind having a look at this when you got time?

@gaiksaya
Copy link
Member

@gaiksaya @peterzhuamazon Do you mind having a look at this when you got time?

Tagging @prudhvigodithi to take a look too. I believe this change needs to wait since it is a breaking change at CI level. We have libraries (example) that would be breaking the entire CI for distribution jobs

@vchrombie
Copy link
Author

vchrombie commented Oct 10, 2023

I believe this change needs to wait since it is a breaking change at CI level. We have libraries (example) that would be breaking the entire CI for distribution jobs

I understand the issue. Should I open a similar PR at opensearch-project/opensearch-build-libraries as well?

@gaiksaya
Copy link
Member

I believe this change needs to wait since it is a breaking change at CI level. We have libraries (example) that would be breaking the entire CI for distribution jobs

I understand the issue. Should I open a similar PR at opensearch-project/opensearch-build-libraries as well?

I believe first listing where all we need to make changes should be the right path to go forward. You can use the GitHub issue to list them and then we can go over the changes required. This will also require change in all the repositories using the opensearch-build-libraries in their jenkins file which is 20+ as of today.
@bbarani @prudhvigodithi Need your input here on how should we proceed if at all.
Thanks!

@vchrombie
Copy link
Author

@bbarani @prudhvigodithi
Do you have any thoughts how we should proceed on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build repo: Move all .sh scripts from root folder to scripts/ folder.
2 participants