-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all the shell scripts to the scripts folder #4099
base: main
Are you sure you want to change the base?
Conversation
This commit also updates the tests and documentation to include the new path of the shell scripts. Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4099 +/- ##
=======================================
Coverage 93.24% 93.24%
=======================================
Files 187 187
Lines 5730 5730
=======================================
Hits 5343 5343
Misses 387 387
|
Some of the python and groovy tests failed, so I am trying to fix them. |
Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
91e3485
to
4e2c1b8
Compare
All the tests should pass now. 🚀 |
Let me know if you want me to squash the commits. |
@gaiksaya @peterzhuamazon |
Tagging @prudhvigodithi to take a look too. I believe this change needs to wait since it is a breaking change at CI level. We have libraries (example) that would be breaking the entire CI for distribution jobs |
I understand the issue. Should I open a similar PR at opensearch-project/opensearch-build-libraries as well? |
I believe first listing where all we need to make changes should be the right path to go forward. You can use the GitHub issue to list them and then we can go over the changes required. This will also require change in all the repositories using the opensearch-build-libraries in their jenkins file which is 20+ as of today. |
@bbarani @prudhvigodithi |
Description
This PR movies all the shell scripts to the scripts folder. It also updates the tests and documentation to include the new path of the shell scripts.
Issues Resolved
Closes #2495
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.