Fix OpenSearch build output for snapshot builds. #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <[email protected]>
mch2
approved these changes
Aug 16, 2021
camerski
approved these changes
Aug 16, 2021
alborotogarcia
pushed a commit
to alborotogarcia/opensearch-build
that referenced
this pull request
Sep 7, 2021
) Signed-off-by: dblock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock [email protected]
Description
The build doesn't correctly name the -min artifact with
-SNAPSHOT. The script is also trying to be a bit too smart, we know exactly what the name of the artifact is and we only need to add-minto it.Made the script a bit more future proof when we decide to build other targets such as Windows.
Finally, I opened opensearch-project/OpenSearch#1094 because there's no reason why the output of OpenSearch repo build shouldn't just be called
-min, we can take care of it when merging this script into it.Issues Resolved
Part of #179
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.