Only check the gcc version ceiling when it is on linux #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
bug
peterzhuamazon
requested review from
heemin32,
navneet1v,
VijayanB and
vamshin
as code owners
peterzhuamazon
requested review from
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
prudhvigodithi
approved these changes
Jul 14, 2023
navneet1v
reviewed
Jul 14, 2023
| @@ -119,7 +119,7 @@ fi | |||
| # https://github.com/opensearch-project/k-NN/issues/975 | |||
| GCC_REQUIRED_VERSION_CEILING=8.0.0 | |||
| COMPARE_VERSION_CEILING=`echo $GCC_REQUIRED_VERSION_CEILING $GCC_VERSION | tr ' ' '\n' | sort -V | uniq | tail -n 1` | |||
| if [ ! "$COMPARE_VERSION_CEILING" = "$GCC_REQUIRED_VERSION_CEILING" ]; then | |||
| if [ "$COMPARE_VERSION_CEILING" != "$GCC_REQUIRED_VERSION_CEILING" ] && (echo "$OSTYPE" | grep -i linux); then | |||
There was a problem hiding this comment.
can we use "$PLATFORM" from top instead ?
There was a problem hiding this comment.
This is temp code specifically for centos7 before we move to rockylinux8.
Both the x64 and the arm64 centos7 image is built based on the same dockerfile thus have same gcc version.
As long as linux is specifically locked to version above 4.9 and lower than 8 we are good.
Codecov Report
@@ Coverage Diff @@
## main #991 +/- ##
=========================================
Coverage 85.13% 85.13%
Complexity 1141 1141
=========================================
Files 154 154
Lines 4683 4683
Branches 423 423
=========================================
Hits 3987 3987
Misses 504 504
Partials 192 192 |
navneet1v
approved these changes
Jul 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 0801408)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 0801408)
navneet1v
pushed a commit
that referenced
this pull request
Jul 14, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 0801408) Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon
added a commit
that referenced
this pull request
Jul 14, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 0801408) Co-authored-by: Peter Zhu <[email protected]>
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only check the gcc version ceiling when it is on linux
Issues Resolved
#975
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.