Fixing the k-nn build for windows platform after upgrading Faiss #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
navneet1v
changed the title
junqiu-lei
approved these changes
Jul 13, 2023
naveentatikonda
approved these changes
Jul 13, 2023
Signed-off-by: Navneet Verma <[email protected]>
jmazanec15
reviewed
Jul 13, 2023
jmazanec15
approved these changes
Jul 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 4c94575)
This was referenced Jul 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 4c94575)
navneet1v
added a commit
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 4c94575) Co-authored-by: Navneet Verma <[email protected]>
navneet1v
added a commit
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 4c94575) Co-authored-by: Navneet Verma <[email protected]>
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the k-nn build for windows platform.
The current build on main branch is broken due to: opensearch-project/OpenSearch@e354201
PR for fixing the main branch: #981
Tested in a windows machine provided by build team.
Issues Resolved
#975
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.