Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Lucene912Codec Issue with BWC for Lucene 10.0.1 upgrade #2429

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vikasht34
Copy link
Contributor

Description

As per Lucene 10.0.1 upgrade, Path of Lucene912Codec has been changed and which is breaking BWC tests.

https://github.com/apache/lucene/blob/main/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene912/Lucene912Codec.java

This PR aims to fix the path to correct Lucene912Codec.

Related Issues

None

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Vikasht34 Vikasht34 force-pushed the CodecFix branch 2 times, most recently from b43056b to 988dcd2 Compare January 23, 2025 20:06
@martin-gaievski
Copy link
Member

it looks like opensearch-knn-test-fixtures needs to consume latest corre main with lucene 10

/home/runner/work/k-NN/k-NN/src/main/java/org/opensearch/knn/index/codec/KNNCodecVersion.java:16: error: package org.apache.lucene.backward_codecs.lucene912 does not exist
import org.apache.lucene.backward_codecs.lucene912.Lucene912Codec;

@Vikasht34
Copy link
Contributor Author

it looks like opensearch-knn-test-fixtures needs to consume latest corre main with lucene 10

/home/runner/work/k-NN/k-NN/src/main/java/org/opensearch/knn/index/codec/KNNCodecVersion.java:16: error: package org.apache.lucene.backward_codecs.lucene912 does not exist
import org.apache.lucene.backward_codecs.lucene912.Lucene912Codec;

Yes ...Agree ...We need to change to alpha !! lots of things started breaking ..This Pr would be updated with all latest changes.

@Vikasht34 Vikasht34 marked this pull request as draft January 24, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants