Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add WithFieldName implementation to KNNQueryBuilder #2400

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[Backport 2.x] Add WithFieldName implementation to KNNQueryBuilder #2400

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7e817f2 from #2398

@markwu-sde @github-actions
Add WithFieldName implementation to KNNQueryBuilder (#2398)
e0df26a 
* Add WithFieldName implementation to KNNQueryBuilder

Signed-off-by: Mark Wu <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Mark Wu <[email protected]>

---------

Signed-off-by: Mark Wu <[email protected]>
(cherry picked from commit 7e817f2)
@kotwanikunal
Copy link
Member 

REPRODUCE WITH: ./gradlew ':qa:restart-upgrade:testRestartUpgrade' --tests "org.opensearch.knn.bwc.WarmupIT.testKNNWarmupCustomLegacyFieldMapping" -Dtests.seed=533DEB8C8C6F32CC -Dtests.security.manager=false -Dtests.bwc.version=1.2.4 -Dtests.locale=es-NI -Dtests.timezone=Asia/Ulaanbaatar -Druntime.java=11

Suite: Test class org.opensearch.knn.bwc.WarmupIT

org.opensearch.knn.bwc.WarmupIT > testKNNWarmupCustomLegacyFieldMapping FAILED
    java.lang.AssertionError: expected:<5> but was:<4>
        at __randomizedtesting.SeedInfo.seed([533DEB8C8C6F32CC:EAA45E6024FA5264]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:647)
        at org.junit.Assert.assertEquals(Assert.java:633)
        at org.opensearch.knn.KNNRestTestCase.validateKNNSearch(KNNRestTestCase.java:1402)
        at org.opensearch.knn.KNNRestTestCase.validateKNNSearch(KNNRestTestCase.java:1385)
        at org.opensearch.knn.bwc.WarmupIT.validateKNNWarmupOnUpgrade(WarmupIT.java:125)
        at org.opensearch.knn.bwc.WarmupIT.testKNNWarmupCustomLegacyFieldMapping(WarmupIT.java:66)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan ryanbogan is a code owner

@luyuncheng luyuncheng Awaiting requested review from luyuncheng luyuncheng is a code owner

@shatejas shatejas Awaiting requested review from shatejas shatejas is a code owner

@0ctopus13prime 0ctopus13prime Awaiting requested review from 0ctopus13prime 0ctopus13prime is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kotwanikunal @markwu-sde