Fixed a bug to prevent updating index.knn setting after index creation #2348
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AnnTian Shao <[email protected]>
anntians
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
Signed-off-by: AnnTian Shao <[email protected]>
Signed-off-by: Tommy Shao <[email protected]>
Signed-off-by: Tommy Shao <[email protected]> Signed-off-by: AnnTian Shao <[email protected]>
jmazanec15
reviewed
Dec 24, 2024
3 tasks
…ng after version upgrade Signed-off-by: Tommy Shao <[email protected]>
jmazanec15
approved these changes
Jan 9, 2025
|
@shatejas / @navneet1v / @Vikasht34 - Can you please review this one? |
VijayanB
approved these changes
Jan 9, 2025
navneet1v
approved these changes
Jan 9, 2025
navneet1v
added
backport 2.x
Bug Fixes
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2348-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a875eb866dcc16086d1410b1cceae88e8cbfc9c5
# Push it to GitHub
git push --set-upstream origin backport/backport-2348-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
|
@anntians can you please port this change for 2.x branch and create a new PR |
anntians
added a commit
to anntians/k-NN
that referenced
this pull request
Jan 10, 2025
opensearch-project#2348) * Change index.knn setting to FINAL, immutable after index creation Signed-off-by: AnnTian Shao <[email protected]> * Add to ChangeLog the description of bug fix Signed-off-by: AnnTian Shao <[email protected]> * Add restart upgrade test for checking immutability of knn.index setting after version upgrade Signed-off-by: Tommy Shao <[email protected]> --------- Signed-off-by: AnnTian Shao <[email protected]> Signed-off-by: Tommy Shao <[email protected]> Signed-off-by: Tommy Shao <[email protected]> Co-authored-by: AnnTian Shao <[email protected]> (cherry picked from commit a875eb8)
anntians
added a commit
to anntians/k-NN
that referenced
this pull request
Jan 10, 2025
opensearch-project#2348) * Change index.knn setting to FINAL, immutable after index creation Signed-off-by: AnnTian Shao <[email protected]> * Add to ChangeLog the description of bug fix Signed-off-by: AnnTian Shao <[email protected]> * Add restart upgrade test for checking immutability of knn.index setting after version upgrade Signed-off-by: Tommy Shao <[email protected]> --------- Signed-off-by: AnnTian Shao <[email protected]> Signed-off-by: Tommy Shao <[email protected]> Signed-off-by: Tommy Shao <[email protected]> Co-authored-by: AnnTian Shao <[email protected]> (cherry picked from commit a875eb8) Signed-off-by: AnnTian Shao <[email protected]>
anntians
added a commit
to anntians/k-NN
that referenced
this pull request
Jan 10, 2025
opensearch-project#2348) * Change index.knn setting to FINAL, immutable after index creation Signed-off-by: AnnTian Shao <[email protected]> * Add to ChangeLog the description of bug fix Signed-off-by: AnnTian Shao <[email protected]> * Add restart upgrade test for checking immutability of knn.index setting after version upgrade Signed-off-by: Tommy Shao <[email protected]> --------- Signed-off-by: AnnTian Shao <[email protected]> Signed-off-by: Tommy Shao <[email protected]> Signed-off-by: Tommy Shao <[email protected]> Co-authored-by: AnnTian Shao <[email protected]> (cherry picked from commit a875eb8)
anntians
added a commit
to anntians/k-NN
that referenced
this pull request
Jan 10, 2025
opensearch-project#2348) * Change index.knn setting to FINAL, immutable after index creation Signed-off-by: AnnTian Shao <[email protected]> * Add to ChangeLog the description of bug fix Signed-off-by: AnnTian Shao <[email protected]> * Add restart upgrade test for checking immutability of knn.index setting after version upgrade Signed-off-by: Tommy Shao <[email protected]> --------- Signed-off-by: AnnTian Shao <[email protected]> Signed-off-by: Tommy Shao <[email protected]> Signed-off-by: Tommy Shao <[email protected]> Co-authored-by: AnnTian Shao <[email protected]> (cherry picked from commit a875eb8)
anntians
added a commit
to anntians/k-NN
that referenced
this pull request
Jan 10, 2025
opensearch-project#2348) * Change index.knn setting to FINAL, immutable after index creation Signed-off-by: AnnTian Shao <[email protected]> * Add to ChangeLog the description of bug fix Signed-off-by: AnnTian Shao <[email protected]> * Add restart upgrade test for checking immutability of knn.index setting after version upgrade Signed-off-by: Tommy Shao <[email protected]> --------- Signed-off-by: AnnTian Shao <[email protected]> Signed-off-by: Tommy Shao <[email protected]> Signed-off-by: Tommy Shao <[email protected]> Co-authored-by: AnnTian Shao <[email protected]> (cherry picked from commit a875eb8) Signed-off-by: AnnTian Shao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change prevents customers to update index.knn setting after creating an index. Previously, there was a loophole to migrate a live k-nn index from hot to UW by closing the index, setting index.knn to false, opening the index, and migrating to UW. However, migrating k-nn indices to UW nodes is not supported. Thus, this PR updates index.knn to be FINAL and immutable after index creation.
Related Issues
Resolves #2334
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.