Fix Faiss efficient filter exact search using byte vector datatype #2165
+690
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
added
Bug Fixes
naveentatikonda
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
|
@naveentatikonda can we add a IT for this change where we do filters testing with Faiss ByteVector |
naveentatikonda
force-pushed
the
fix_byte_vector_exact_search
branch
from
faeffe5
to
beb98d0
Compare
Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
force-pushed
the
fix_byte_vector_exact_search
branch
from
beb98d0
to
eaf02fe
Compare
shatejas
reviewed
Sep 30, 2024
src/main/java/org/opensearch/knn/index/query/iterators/ByteVectorIdsKNNIterator.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/knn/index/query/iterators/BinaryVectorIdsKNNIteratorTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Naveen Tatikonda <[email protected]>
shatejas
approved these changes
Sep 30, 2024
ryanbogan
approved these changes
Sep 30, 2024
VijayanB
approved these changes
Sep 30, 2024
heemin32
approved these changes
Sep 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…2165) * Fix Faiss efficient filter exact search using byte vector datatype Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> --------- Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit 6d098cf)
naveentatikonda
added a commit
that referenced
this pull request
Sep 30, 2024
…2165) * Fix Faiss efficient filter exact search using byte vector datatype Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> --------- Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit 6d098cf) Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
added a commit
that referenced
this pull request
Oct 1, 2024
…2165) (#2171) * Fix Faiss efficient filter exact search using byte vector datatype * Address Review Comments --------- (cherry picked from commit 6d098cf) Signed-off-by: Naveen Tatikonda <[email protected]> Co-authored-by: Naveen Tatikonda <[email protected]>
jmazanec15
pushed a commit
that referenced
this pull request
Oct 1, 2024
…2165) * Fix Faiss efficient filter exact search using byte vector datatype Signed-off-by: Naveen Tatikonda <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> --------- Signed-off-by: Naveen Tatikonda <[email protected]> Signed-off-by: John Mazanec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Faiss efficient filter exact search using byte vector datatype
Issues Resolved
#2168
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.