Added NMSLIB patched allowing load/write APIs with a stream object. #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ctopus13prime
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
0ctopus13prime
force-pushed
the
nmslib-patch
branch
from
20d5e34
to
1bdcd9d
Compare
|
Thanks @0ctopus13prime . Can you update the CMake file with this patch so it gets built? See https://github.com/opensearch-project/k-NN/blob/main/DEVELOPER_GUIDE.md#custom-patch-on-jni-library |
jmazanec15
reviewed
Sep 25, 2024
jni/patches/nmslib/0003-Added-LoadIndexWithStream-and-SaveIndexWithStream.patch
Outdated
Show resolved
Hide resolved
jmazanec15
reviewed
Sep 25, 2024
jni/patches/nmslib/0003-Added-LoadIndexWithStream-and-SaveIndexWithStream.patch
Outdated
Show resolved
Hide resolved
Sure, will do in the next revision. |
0ctopus13prime
force-pushed
the
nmslib-patch
branch
from
1bdcd9d
to
2ed56ab
Compare
Signed-off-by: Dooyong Kim <[email protected]>
0ctopus13prime
force-pushed
the
nmslib-patch
branch
from
2ed56ab
to
07ff6f1
Compare
heemin32
approved these changes
Sep 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
…2144) Signed-off-by: Dooyong Kim <[email protected]> Co-authored-by: Dooyong Kim <[email protected]> (cherry picked from commit eba9d98)
jmazanec15
pushed a commit
that referenced
this pull request
Oct 2, 2024
…2144) Signed-off-by: Dooyong Kim <[email protected]> Co-authored-by: Dooyong Kim <[email protected]> (cherry picked from commit eba9d98) Signed-off-by: John Mazanec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
This patch adds two new methods in NMSLIB that accepts stream objects to let its internal hnsw can read and write bytes. Which will eventually trigger Lucene’s IndexInput in the PR to be raised.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.