-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds index and query BWC tests for missing engines #2035
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shatejas
force-pushed
the
tighten-bwc-tests
branch
11 times, most recently
from
September 6, 2024 23:02
9402b0c
to
c44fddf
Compare
This is done to make sure that KNN80DocsValueConsumer code path is hit Signed-off-by: Tejas Shah <[email protected]>
shatejas
force-pushed
the
tighten-bwc-tests
branch
from
September 9, 2024 18:44
c44fddf
to
78d07e2
Compare
shatejas
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
September 9, 2024 19:15
navneet1v
reviewed
Sep 10, 2024
navneet1v
reviewed
Sep 10, 2024
navneet1v
approved these changes
Sep 11, 2024
heemin32
approved these changes
Sep 11, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2035-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e3200260e7360f6ff90600535ac759d11cb1fefb
# Push it to GitHub
git push --set-upstream origin backport/backport-2035-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Sep 11, 2024
…t#2035) This is done to make sure that KNN80DocsValueConsumer code path is hit Signed-off-by: Tejas Shah <[email protected]> (cherry picked from commit e320026)
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Sep 11, 2024
…t#2035) This is done to make sure that KNN80DocsValueConsumer code path is hit Signed-off-by: Tejas Shah <[email protected]> (cherry picked from commit e320026)
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Sep 12, 2024
…t#2035) This is done to make sure that KNN80DocsValueConsumer code path is hit Signed-off-by: Tejas Shah <[email protected]> (cherry picked from commit e320026)
5 tasks
ryanbogan
pushed a commit
that referenced
this pull request
Sep 12, 2024
This is done to make sure that KNN80DocsValueConsumer code path is hit Signed-off-by: Tejas Shah <[email protected]> (cherry picked from commit e320026)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is done to make sure that KNN80DocsValueConsumer code path is hit
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.