Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds index and query BWC tests for missing engines #2035

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

shatejas
Copy link
Collaborator

@shatejas shatejas commented Sep 4, 2024

Description

This is done to make sure that KNN80DocsValueConsumer code path is hit

Check List

  • New functionality includes testing.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shatejas shatejas force-pushed the tighten-bwc-tests branch 11 times, most recently from 9402b0c to c44fddf Compare September 6, 2024 23:02
This is done to make sure that KNN80DocsValueConsumer code path is hit

Signed-off-by: Tejas Shah <[email protected]>
@heemin32 heemin32 merged commit e320026 into opensearch-project:main Sep 11, 2024
27 of 41 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2035-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e3200260e7360f6ff90600535ac759d11cb1fefb
# Push it to GitHub
git push --set-upstream origin backport/backport-2035-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2035-to-2.x.

shatejas added a commit to shatejas/k-NN that referenced this pull request Sep 11, 2024
…t#2035)

This is done to make sure that KNN80DocsValueConsumer code path is hit

Signed-off-by: Tejas Shah <[email protected]>
(cherry picked from commit e320026)
shatejas added a commit to shatejas/k-NN that referenced this pull request Sep 11, 2024
…t#2035)

This is done to make sure that KNN80DocsValueConsumer code path is hit

Signed-off-by: Tejas Shah <[email protected]>
(cherry picked from commit e320026)
shatejas added a commit to shatejas/k-NN that referenced this pull request Sep 12, 2024
…t#2035)

This is done to make sure that KNN80DocsValueConsumer code path is hit

Signed-off-by: Tejas Shah <[email protected]>
(cherry picked from commit e320026)
ryanbogan pushed a commit that referenced this pull request Sep 12, 2024
This is done to make sure that KNN80DocsValueConsumer code path is hit

Signed-off-by: Tejas Shah <[email protected]>
(cherry picked from commit e320026)
@shatejas shatejas deleted the tighten-bwc-tests branch September 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants