Skip to content

Commit

Permalink
[Maintenance]Enable indices.breaker.total.use_real_memory setting for…
Browse files Browse the repository at this point in the history
… integTest cluster (#2395)

Enable indices.breaker.total.use_real_memory setting for integTest Cluster  vai build.gradle for catching heap CB in local integration testing.

Signed-off-by: Rajvaibhav Rahane <[email protected]>
  • Loading branch information
Rajrahane authored Jan 17, 2025
1 parent 7e817f2 commit eecb45c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,5 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
* Added Lucene BWC tests (#2313)[https://github.com/opensearch-project/k-NN/pull/2313]
* Upgrade jsonpath from 2.8.0 to 2.9.0[2325](https://github.com/opensearch-project/k-NN/pull/2325)
* Bump Faiss commit from 1f42e81 to 0cbc2a8 to accelerate hamming distance calculation using _mm512_popcnt_epi64 intrinsic and also add avx512-fp16 instructions to boost performance [#2381](https://github.com/opensearch-project/k-NN/pull/2381)
* Enabled indices.breaker.total.use_real_memory setting via build.gradle for integTest Cluster to catch heap CB in local ITs and github CI actions [#2395](https://github.com/opensearch-project/k-NN/pull/2395/)
### Refactoring
11 changes: 11 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,15 @@ ext {
)
cluster.setSecure(true)
}
propertyKeys = [
breaker: [
useRealMemory: 'tests.opensearch.indices.breaker.total.use_real_memory'
]
]
}

def getBreakerSetting() {
return System.getProperty(propertyKeys.breaker.useRealMemory, 'true')
}

allprojects {
Expand Down Expand Up @@ -399,6 +408,7 @@ integTest {
if (System.getProperty("test.debug") != null) {
jvmArgs '-agentlib:jdwp=transport=dt_socket,server=n,suspend=y,address=8000'
}
systemProperty propertyKeys.breaker.useRealMemory, getBreakerSetting()
}

testClusters.integTest {
Expand Down Expand Up @@ -428,6 +438,7 @@ testClusters.integTest {
}
}
systemProperty("java.library.path", "$rootDir/jni/release")
systemProperty propertyKeys.breaker.useRealMemory, getBreakerSetting()
}

task integTestRemote(type: RestIntegTestTask) {
Expand Down

0 comments on commit eecb45c

Please sign in to comment.