Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out the old cluster state metadata logic #963

Merged

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Sep 30, 2023

Issue #, if available:

Description of changes:

A follow up on #771 , clean remaining cluster state metadata logic
In TransportExplainAction, only doing a minimal change, since it's still no time for 3.0 release, need to reduce the backport friction until then.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #963 (40174cc) into main (a2dd769) will increase coverage by 0.41%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##               main     #963      +/-   ##
============================================
+ Coverage     75.55%   75.97%   +0.41%     
+ Complexity     2842     2823      -19     
============================================
  Files           364      361       -3     
  Lines         16263    16074     -189     
  Branches       2343     2314      -29     
============================================
- Hits          12288    12212      -76     
+ Misses         2626     2537      -89     
+ Partials       1349     1325      -24     
Files Coverage Δ
...pensearch/indexmanagement/IndexManagementPlugin.kt 89.45% <ø> (-0.25%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 71.83% <ø> (+2.73%) ⬆️
...agement/indexstatemanagement/ManagedIndexRunner.kt 47.88% <ø> (+0.52%) ⬆️
...temanagement/opensearchapi/OpenSearchExtensions.kt 69.33% <ø> (+0.97%) ⬆️
...t/settings/LegacyOpenDistroManagedIndexSettings.kt 98.36% <ø> (-0.21%) ⬇️
...exstatemanagement/settings/ManagedIndexSettings.kt 98.36% <ø> (-0.20%) ⬇️
...action/changepolicy/TransportChangePolicyAction.kt 67.53% <100.00%> (+1.88%) ⬆️
...action/removepolicy/TransportRemovePolicyAction.kt 64.89% <ø> (-0.19%) ⬇️
...gedindex/TransportRetryFailedManagedIndexAction.kt 67.78% <100.00%> (+1.11%) ⬆️
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 76.88% <ø> (+7.14%) ⬆️
... and 3 more

... and 9 files with indirect coverage changes

@bowenlan-amzn bowenlan-amzn changed the title Refactor out the old cluster state metadata Refactor out the old cluster state metadata logic Oct 1, 2023
@bowenlan-amzn bowenlan-amzn merged commit 3e80cff into opensearch-project:main Oct 3, 2023
15 checks passed
@bowenlan-amzn bowenlan-amzn deleted the refactor-ism-runner branch October 3, 2023 17:20
Joshua152 pushed a commit to Joshua152/index-management that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants