[Backport 2.x] Handle NPE in isRollupIndex #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Handle NPE in isRollupIndex `metadata.index()` can return `null`, so handle that case by returning `false`. Signed-off-by: Bryce Lampe <[email protected]> * unit test Signed-off-by: Bryce Lampe <[email protected]> --------- Signed-off-by: Bryce Lampe <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> (cherry picked from commit 05bc0d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws and
gaobinlong
as code owners
opensearch-trigger-bot
bot
requested review from
Hailong-am,
amsiglan,
sbcd90,
eirsep and
AWSHurneyt
as code owners
bowenlan-amzn
approved these changes
Jul 22, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #871 +/- ##
============================================
- Coverage 76.06% 76.05% -0.02%
- Complexity 2908 2912 +4
============================================
Files 366 366
Lines 16558 16561 +3
Branches 2397 2398 +1
============================================
Hits 12595 12595
- Misses 2582 2584 +2
- Partials 1381 1382 +1
|
AWSHurneyt
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 05bc0d5 from #855.