64: Added rounding when using aggreagate script for avg metric. Added… #490
+72
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
============================================
- Coverage 75.94% 75.76% -0.18%
+ Complexity 2480 2474 -6
============================================
Files 315 315
Lines 14500 14500
Branches 2243 2243
============================================
- Hits 11012 10986 -26
- Misses 2239 2255 +16
- Partials 1249 1259 +10 ☔ View full report in Codecov by Sentry. |
… unit tests for checking average aggregations against the target rollup index Signed-off-by: Stevan Buzejic <[email protected]>
Signed-off-by: Stevan Buzejic <[email protected]>
Signed-off-by: Stevan Buzejic <[email protected]>
stevanbz
force-pushed
the
bugfix/64-avg-rollup-target-idx-metric
branch
from
56d31de
to
b2d508e
Compare
Angie-Zhang
approved these changes
Sep 9, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
#490) * 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index Signed-off-by: Stevan Buzejic <[email protected]> * 64: Rollup job renamed Signed-off-by: Stevan Buzejic <[email protected]> * 64: Removed unrelevant metrics for the avg calculation test Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> (cherry picked from commit fadc553)
Angie-Zhang
pushed a commit
that referenced
this pull request
Oct 4, 2022
#490) (#504) * 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index Signed-off-by: Stevan Buzejic <[email protected]> * 64: Rollup job renamed Signed-off-by: Stevan Buzejic <[email protected]> * 64: Removed unrelevant metrics for the avg calculation test Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> (cherry picked from commit fadc553) Co-authored-by: Stevan Buzejic <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
#490) * 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index Signed-off-by: Stevan Buzejic <[email protected]> * 64: Rollup job renamed Signed-off-by: Stevan Buzejic <[email protected]> * 64: Removed unrelevant metrics for the avg calculation test Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> (cherry picked from commit fadc553)
Angie-Zhang
added a commit
that referenced
this pull request
Oct 14, 2022
* initial framework Signed-off-by: Joanne Wang <[email protected]> * Removed recursion from Explain Action to avoid stackoverflow in some situations (#419) Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Joanne Wang <[email protected]> * enabled by default integrated Signed-off-by: Joanne Wang <[email protected]> * cleaned up comments and logs, created unit test and updated previous integration tests Signed-off-by: Joanne Wang <[email protected]> * added delete validation logic Signed-off-by: Joanne Wang <[email protected]> * fixed rollover validation unit tests Signed-off-by: Joanne Wang <[email protected]> * added validation info field to ManagedIndexMetaData Signed-off-by: Joanne Wang <[email protected]> * removed step context as input Signed-off-by: Joanne Wang <[email protected]> * added validationmetadata class Signed-off-by: Joanne Wang <[email protected]> * restored old integration tests and changed validation service output Signed-off-by: Joanne Wang <[email protected]> * before integrated validation meta data into managed index meta data Signed-off-by: Joanne Wang <[email protected]> * integrated validation meta data Signed-off-by: Joanne Wang <[email protected]> * working version Signed-off-by: Joanne Wang <[email protected]> * added validation mapping Signed-off-by: Joanne Wang <[email protected]> * fixed integ tests Signed-off-by: Joanne Wang <[email protected]> * renamed some values Signed-off-by: Joanne Wang <[email protected]> * before removing from managed index meta data Signed-off-by: Joanne Wang <[email protected]> * created validation result object in explain Signed-off-by: Joanne Wang <[email protected]> * testing Signed-off-by: Joanne Wang <[email protected]> * run fails Signed-off-by: Joanne Wang <[email protected]> * integration test for delete + added framework for force merge Signed-off-by: Joanne Wang <[email protected]> * removed step validation metadata and still testing explain results Signed-off-by: Joanne Wang <[email protected]> * before removing from managed index runner Signed-off-by: Joanne Wang <[email protected]> * removed from managed index runner Signed-off-by: Joanne Wang <[email protected]> * clean up and tests Signed-off-by: Joanne Wang <[email protected]> * all validation tests pass Signed-off-by: Joanne Wang <[email protected]> * removed validation result from all managed index meta data Signed-off-by: Joanne Wang <[email protected]> * restored old IT tests Signed-off-by: Joanne Wang <[email protected]> * fixed it tests, set explain validation to false Signed-off-by: Joanne Wang <[email protected]> * clean up Signed-off-by: Joanne Wang <[email protected]> * Change test page size to avoid index/search TimeInMillis < 1 issue. (#460) * Change test page size to avoid indexTimeInMillis < 1 issue. Signed-off-by: Angie Zhang <[email protected]> * Change test page size to avoid indexTimeInMillis < 1 issue. Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Angie Zhang <[email protected]> * Transform maxclauses fix (#477) * transform maxClauses fix Signed-off-by: Petar Dzepina <[email protected]> * added bucket log to track processed buckets Signed-off-by: Petar Dzepina <[email protected]> * various renames/changes Signed-off-by: Petar Dzepina <[email protected]> * fixed detekt issues Signed-off-by: Petar Dzepina <[email protected]> * added comments to test Signed-off-by: Petar Dzepina <[email protected]> * removed debug logging Signed-off-by: Petar Dzepina <[email protected]> * empty commit to trigger checks Signed-off-by: Petar Dzepina <[email protected]> * reduced pageSize to 1 in few ITs to avoid flaky tests; fixed bug where pagesProcessed was calculated incorrectly Signed-off-by: Petar Dzepina <[email protected]> * reverted pagesProcessed change; fixed few ITs Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> * 483: Updated detekt plugin and snakeyaml dependency. Updated a code t… (#485) * 483: Updated detekt plugin and snakeyaml dependency. Updated a code to reduce the number of issues after static analysis Signed-off-by: Stevan Buzejic <[email protected]> * 483: Updated snakeyaml version to use the latest Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> * Remove HOST_DENY_LIST usage as Notification plugin will own it (#471) (#107) Signed-off-by: Xuesong Luo <[email protected]> Signed-off-by: Xuesong Luo <[email protected]> * Disable detekt because of the CVE (#497) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> * Deprecate Master nonmenclature (#501) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> * [AUTO] Increment version to 2.3.0-SNAPSHOT (#484) (#503) * fix#921-README-forum-link-index_mgmnt (#499) Signed-off-by: cwillum <[email protected]> Signed-off-by: cwillum <[email protected]> * 64: Added rounding when using aggreagate script for avg metric. Added… (#490) * 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index Signed-off-by: Stevan Buzejic <[email protected]> * 64: Rollup job renamed Signed-off-by: Stevan Buzejic <[email protected]> * 64: Removed unrelevant metrics for the avg calculation test Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> * Revert Disable detekt and force choose snakeyml 1.32 (#528) * Revert Disable detekt: 50ac1e9 Signed-off-by: Siddhant Deshmukh <[email protected]> * Remove force choosing snakeyml 1.31 Signed-off-by: Siddhant Deshmukh <[email protected]> * Force snakeyaml 1.32 Signed-off-by: Siddhant Deshmukh <[email protected]> * Empty commit Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> * Added 2.3 release note (#507) (#515) (#517) * Update 2.3 release note Signed-off-by: Angie Zhang <[email protected]> * Update 2.3 release note Signed-off-by: Angie Zhang <[email protected]> * Update 2.3 release note Signed-off-by: Angie Zhang <[email protected]> * Update 2.3 release note Signed-off-by: Angie Zhang <[email protected]> * Update 2.3 release note Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Angie Zhang <[email protected]> (cherry picked from commit d9793ac) Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Angie Zhang <[email protected]> (cherry picked from commit 7217b5b) Co-authored-by: Angie Zhang <[email protected]> * Add 2.2 release note (#450) (#452) (#516) * Add 2.2 release note Signed-off-by: Angie Zhang <[email protected]> * Add 2.2 release note Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Angie Zhang <[email protected]> (cherry picked from commit 8eb5da6) Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Co-authored-by: Ashish Agrawal <[email protected]> * Adds plugin version sweep background job (#434) * [207]: Added 5 min scheduled job for sweeping ISM plugin version in the case of version discrepancy Signed-off-by: Stevan Buzejic <[email protected]> * [207]: Created pluginVersionSweepCoordinator component responsible for scheduling the skip execution task. Annotated tests in order to prevent thread leak error during integrational tests Signed-off-by: Stevan Buzejic <[email protected]> * [207]: Increased retry period for background job that sets the skip flag up to 5 mins Signed-off-by: Stevan Buzejic <[email protected]> * Empty-Commit Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> Co-authored-by: Stevan Buzejic <[email protected]> * flaky transform test fix attempt (#542) * flaky transform test fix attempt Signed-off-by: Petar Dzepina <[email protected]> * accidental paste fix Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Co-authored-by: Petar Dzepina <[email protected]> Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Angie Zhang <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Xuesong Luo <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: cwillum <[email protected]> Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: Petar Dzepina <[email protected]> Co-authored-by: Petar <[email protected]> Co-authored-by: Angie Zhang <[email protected]> Co-authored-by: Stevan Buzejic <[email protected]> Co-authored-by: xluo-aws <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Chris Moore <[email protected]> Co-authored-by: Siddhant Deshmukh <[email protected]> Co-authored-by: Angie Zhang <[email protected]> Co-authored-by: Ashish Agrawal <[email protected]> Co-authored-by: Clay Downs <[email protected]> Co-authored-by: Stevan Buzejic <[email protected]> Co-authored-by: Petar Dzepina <[email protected]>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
opensearch-project#490) (opensearch-project#504) * 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index Signed-off-by: Stevan Buzejic <[email protected]> * 64: Rollup job renamed Signed-off-by: Stevan Buzejic <[email protected]> * 64: Removed unrelevant metrics for the avg calculation test Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> (cherry picked from commit fadc553) Co-authored-by: Stevan Buzejic <[email protected]>
ronnaksaxena
pushed a commit
to ronnaksaxena/index-management
that referenced
this pull request
Jul 19, 2023
opensearch-project#490) (opensearch-project#504) * 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index Signed-off-by: Stevan Buzejic <[email protected]> * 64: Rollup job renamed Signed-off-by: Stevan Buzejic <[email protected]> * 64: Removed unrelevant metrics for the avg calculation test Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> (cherry picked from commit fadc553) Co-authored-by: Stevan Buzejic <[email protected]> Signed-off-by: Ronnak Saxena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… unit tests for checking average aggregations against the target rollup index
Signed-off-by: Stevan Buzejic [email protected]
Issue #, if available:
Added double summing the avg values when using avg metric
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.