Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Add Service Monitor Resource #578

Merged

Conversation

VILJkid
Copy link
Contributor

@VILJkid VILJkid commented Aug 23, 2024

Description

It would add a prometheus serviceMonitor resource.

Check List

  • Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

  • Helm chart version bumped
  • Helm chart CHANGELOG.md updated to reflect change

PR sponsored by Obmondo

@prudhvigodithi
Copy link
Member

Thanks @VILJkid should we wait until this fix is pushed #579 (comment) ?
@getsaurabh02 @peterzhuamazon

@VILJkid
Copy link
Contributor Author

VILJkid commented Aug 23, 2024

Thanks for the update, @prudhvigodithi!
I'll keep an eye on that, and update this PR accordingly.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterzhuamazon
Copy link
Member

Pending fix:

@peterzhuamazon
Copy link
Member

Pending fix:

* [[Fix] OpenSearch and OpenSearch Dashboards Service Monitor Bug #581](https://github.com/opensearch-project/helm-charts/pull/581)

Since this is merged now would you mind update this PR to include above changes?
Thanks @VILJkid !

@VILJkid
Copy link
Contributor Author

VILJkid commented Aug 29, 2024

Thanks @peterzhuamazon, I'll update this PR with the changes shortly.

@VILJkid VILJkid force-pushed the serviceMonitor-backport branch 2 times, most recently from 7253041 to e1dabb9 Compare August 29, 2024 05:10
@VILJkid
Copy link
Contributor Author

VILJkid commented Aug 29, 2024

@peterzhuamazon, kindly review the changes and let me know if it needs any improvement.
Thanks!

@peterzhuamazon
Copy link
Member

Thanks @VILJkid , adding @prudhvigodithi to take a second pass.

@peterzhuamazon
Copy link
Member

Waiting for @prudhvigodithi to give a second approval.

Thanks.

@prudhvigodithi
Copy link
Member

There is a new bug created #588, @VILJkid can you please take a look before we merge this?
Thank you

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VILJkid
Copy link
Contributor Author

VILJkid commented Sep 4, 2024

Thanks @prudhvigodithi, @peterzhuamazon for highlighting the issue.
Here's the fix PR: #589
Let me know if it needs any improvements.

@peterzhuamazon
Copy link
Member

Thanks @prudhvigodithi, @peterzhuamazon for highlighting the issue. Here's the fix PR: #589 Let me know if it needs any improvements.

Thanks @VILJkid I have merged that PR now.
Please go ahead and backport the changes here as well.

Thanks!

@VILJkid VILJkid force-pushed the serviceMonitor-backport branch from 5c40d38 to 23f6ff7 Compare September 6, 2024 08:56
Signed-off-by: VILJkid <[email protected]>

(clean) : redundant code

Signed-off-by: VILJkid <[email protected]>

(fix) : incorporate changes from pr#581

Signed-off-by: VILJkid <[email protected]>

(add) : protocol setting for service metrics

Signed-off-by: VILJkid <[email protected]>
@VILJkid VILJkid force-pushed the serviceMonitor-backport branch from 23f6ff7 to a093e19 Compare September 6, 2024 08:57
@VILJkid
Copy link
Contributor Author

VILJkid commented Sep 6, 2024

Thanks @peterzhuamazon @prudhvigodithi!
I've updated this PR accordingly. Kindly review and let me know your thoughts.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VILJkid !

@peterzhuamazon peterzhuamazon merged commit bbd8158 into opensearch-project:1.x Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants