Correct defaults for opensearchJavaOpts in README #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joel Eidsath <[email protected]>
Signed-off-by: Joel Eidsath <[email protected]>
Signed-off-by: Joel Eidsath <[email protected]>
jeidsath
requested review from
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
|
Hi @TheAlgo @prudhvigodithi can we confirm this is the case? Thanks @jeidsath. |
|
Hey @peterzhuamazon, The current default setting can be seen on line 146 of values.yaml We only noticed this because our running cluster did not match the documented default memory usage. Rather than changing the README, it would also be an option to adjust values.yaml to match the documented default. But as this would silently double memory usage for anyone automatically upgrading their clusters (with flux, etc.), the README change seemed like a simpler option. |
peterzhuamazon
approved these changes
Aug 13, 2024
|
Thanks @jeidsath , merged. Thanks. |
peterzhuamazon
pushed a commit
to peterzhuamazon/helm-charts
that referenced
this pull request
Aug 13, 2024
…#570) * Update README.md opensearchJavaOpts defaults Signed-off-by: Joel Eidsath <[email protected]> * version to 2.22.1 Signed-off-by: Joel Eidsath <[email protected]> * 2.22.1 in CHANGELOG.md Signed-off-by: Joel Eidsath <[email protected]> --------- Signed-off-by: Joel Eidsath <[email protected]> Signed-off-by: Peter Zhu <[email protected]>
3 tasks
|
nvm, I backported: #571 Thanks. |
peterzhuamazon
added a commit
to peterzhuamazon/helm-charts
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added a commit
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added a commit
that referenced
this pull request
Aug 13, 2024
* Update README.md opensearchJavaOpts defaults * version to 2.22.1 * 2.22.1 in CHANGELOG.md --------- Signed-off-by: Joel Eidsath <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Joel Eidsath <[email protected]>
VILJkid
pushed a commit
to Obmondo/helm-charts-1
that referenced
this pull request
Aug 21, 2024
…#570) * Update README.md opensearchJavaOpts defaults Signed-off-by: Joel Eidsath <[email protected]> * version to 2.22.1 Signed-off-by: Joel Eidsath <[email protected]> * 2.22.1 in CHANGELOG.md Signed-off-by: Joel Eidsath <[email protected]> --------- Signed-off-by: Joel Eidsath <[email protected]> Signed-off-by: VILJkid <[email protected]>
VILJkid
pushed a commit
to Obmondo/helm-charts-1
that referenced
this pull request
Aug 21, 2024
Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: VILJkid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct defaults for opensearchJavaOpts in README
Issues Resolved
#566
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.