add plugins.removeList to allow remove plugins #526
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
requested review from
bbarani,
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
resolved opensearch-project#383 Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
force-pushed
the
feature-plugin-remove-list
branch
from
38f9da3 to
704bc9d
Compare
There was a problem hiding this comment.
Hi @ruanyl ,
Please make sure you update the changelog and versions.
And address the few comments I posted. Thanks 😄
| @@ -365,6 +365,12 @@ spec: | |||
| #!/usr/bin/env bash | |||
| set -euo pipefail | |||
| {{- range $plugin := .Values.plugins.removeList }} | |||
| if ./bin/opensearch-plugin list | grep -q {{ $plugin }}; then | |||
There was a problem hiding this comment.
Why is there a different behavior b/w os and osd plugin removal?
Is it necessary to do a check before OS removal but not OSD?
| @@ -278,6 +278,8 @@ plugins: | |||
| enabled: false | |||
| installList: [] | |||
| # - example-fake-plugin-downloadable-url | |||
| removeList: [] | |||
| # - securityDashboards | |||
There was a problem hiding this comment.
Change this to something like - examplePluginName or similar.
| @@ -491,6 +491,8 @@ plugins: | |||
| enabled: false | |||
| installList: [] | |||
| # - example-fake-plugin | |||
| removeList: [] | |||
| # - opensearch-ml | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the development phase, it's common to deploy a cluster with plugins that are still in progress. To facilitate the installation of these plugins, the current approach involves removing existing plugins and then installing the development versions. This process often requires manual intervention.
This pull request addresses this issue by introducing the
removeListto the Helm charts. With this enhancement, we can manage the installation and removal of plugins with eliminating the need for manual intervention.Addresses the issue described in #383, where user encountered challenges related to plugin removal.
Issues Resolved
resolved #383
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.