Skip to content

Commit

Permalink
fix: use consistent k8s API semver comparison logic (#19)
Browse files Browse the repository at this point in the history
This is required to work around bugs in the version string returned by
kubernetes distros such as EKS and GKE, where they have invalid Semantic
Version strings. See helm/helm#3810.

Signed-off-by: Scott Leggett <[email protected]>
  • Loading branch information
smlx authored Sep 21, 2021
1 parent d870fd9 commit 55496bb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion charts/opensearch-dashboards/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
{{- end }}
{{- end }}
rules:
{{- if semverCompare ">=1.19" .Capabilities.KubeVersion.Version -}}
{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.Version -}}
{{- range .Values.ingress.hosts }}
- host: {{ .host | quote }}
http:
Expand Down

0 comments on commit 55496bb

Please sign in to comment.