Fix and Refactor Test with Builder Pattern for Issue #2825 #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junwei Dai <[email protected]>
junweid62
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
reviewed
Sep 6, 2024
src/test/java/org/opensearch/flowframework/workflow/DeployModelStepTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Junwei Dai <[email protected]>
dbwiddis
approved these changes
Sep 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
=========================================
Coverage 77.55% 77.55%
Complexity 966 966
=========================================
Files 97 97
Lines 4531 4531
Branches 422 422
=========================================
Hits 3514 3514
Misses 835 835
Partials 182 182 ☔ View full report in Codecov by Sentry. |
jackiehanyang
approved these changes
Sep 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Fix: Use @builder for constructor in test Signed-off-by: Junwei Dai <[email protected]> * Fix: change parameter for different test case Signed-off-by: Junwei Dai <[email protected]> --------- Signed-off-by: Junwei Dai <[email protected]> Co-authored-by: Junwei Dai <[email protected]> (cherry picked from commit 1b055e8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Fix: Use @builder for constructor in test Signed-off-by: Junwei Dai <[email protected]> * Fix: change parameter for different test case Signed-off-by: Junwei Dai <[email protected]> --------- Signed-off-by: Junwei Dai <[email protected]> Co-authored-by: Junwei Dai <[email protected]> (cherry picked from commit 1b055e8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Sep 7, 2024
…#2825 (#861) Fix and Refactor Test with Builder Pattern for Issue #2825 (#859) * Fix: Use @builder for constructor in test * Fix: change parameter for different test case --------- (cherry picked from commit 1b055e8) Signed-off-by: Junwei Dai <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Junwei Dai <[email protected]>
dbwiddis
pushed a commit
that referenced
this pull request
Sep 7, 2024
…2825 (#860) Fix and Refactor Test with Builder Pattern for Issue #2825 (#859) * Fix: Use @builder for constructor in test * Fix: change parameter for different test case --------- (cherry picked from commit 1b055e8) Signed-off-by: Junwei Dai <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Junwei Dai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensured compatibility with the new parameter added in opensearch-project/ml-commons#2825.
Related Issues
Resolves #858
Should fix compile errors causing #856.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.