[Backport 2.x] Replace all CompletableFutures with PlainActionFutures #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Intial commit to remove CompletableFuture Signed-off-by: Owais Kazi <[email protected]> * Removed CompletableFuture from ProcessNode and tests Signed-off-by: Owais Kazi <[email protected]> * Removed CompletableFuture from create index and pipeline workflow steps Signed-off-by: Owais Kazi <[email protected]> * Passing tests Signed-off-by: Owais Kazi <[email protected]> * Addressed initial comments Signed-off-by: Owais Kazi <[email protected]> * Move log line Signed-off-by: Daniel Widdis <[email protected]> * Reenable multi-node tests Signed-off-by: Daniel Widdis <[email protected]> * Disable fail-fast Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: Daniel Widdis <[email protected]> (cherry picked from commit 92d9108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
approved these changes
Jan 22, 2024
|
@dbwiddis is the failing test for mac-os just flaky here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 92d9108 from #419.