Use provisioning thread pool in Process Node #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
amitgalitz
approved these changes
Jan 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
=========================================
Coverage 72.30% 72.30%
Complexity 578 578
=========================================
Files 72 72
Lines 2986 2986
Branches 231 232 +1
=========================================
Hits 2159 2159
Misses 723 723
Partials 104 104 ☔ View full report in Codecov by Sentry. |
owaiskazi19
reviewed
Jan 5, 2024
src/main/java/org/opensearch/flowframework/workflow/ProcessNode.java
Outdated
Show resolved
Hide resolved
owaiskazi19
approved these changes
Jan 5, 2024
src/main/java/org/opensearch/flowframework/common/CommonValue.java
Outdated
Show resolved
Hide resolved
|
Flaky tests will be handled by #377 |
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
process-node-thread
branch
from
f830269
to
6fe39a2
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
(cherry picked from commit 7419e9f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 5, 2024
(cherry picked from commit 7419e9f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses our own provisioning thread pool instead of the generic thread pool in the
ProcessNode. (All other thread pool usages are already using it.)Issues Resolved
Fixes #366
Fixes #61
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.