-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQL PIT reference #8541
base: main
Are you sure you want to change the base?
Add SQL PIT reference #8541
Conversation
Signed-off-by: Simeon Widdis <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Simeon Widdis <[email protected]>
@kolchfa-aws ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Swiddis! One suggestion.
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Simeon Widdis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Swiddis @kolchfa-aws LGTM!
@Swiddis Do you have the code merged already (can we merge this PR)? |
It's done in main, but there's still some backporting work to do for this, I'll get back when we're fully merged. |
@kolchfa-aws merged in SQL, ready to merge here now |
Description
Adds a short section to the PIT page indicating that SQL is capable of it too -- this is a new feature in 2.18. Previously SQL internally used the scroll feature leading to inconsistent pages across time.
Issues Resolved
N/A
Version
2.18
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.