Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL PIT reference #8541

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Swiddis
Copy link
Contributor

@Swiddis Swiddis commented Oct 15, 2024

Description

Adds a short section to the PIT page indicating that SQL is capable of it too -- this is a new feature in 2.18. Previously SQL internally used the scroll feature leading to inconsistent pages across time.

Issues Resolved

N/A

Version

2.18

Frontend features

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Copy link
Contributor Author

Swiddis commented Oct 15, 2024

@kolchfa-aws ready for review

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Swiddis! One suggestion.

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
@kolchfa-aws kolchfa-aws added v2.18.0 release-notes PR: Include this PR in the automated release notes labels Oct 15, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws
Copy link
Collaborator

@Swiddis Do you have the code merged already (can we merge this PR)?

@Swiddis
Copy link
Contributor Author

Swiddis commented Oct 15, 2024

It's done in main, but there's still some backporting work to do for this, I'll get back when we're fully merged.

@kolchfa-aws kolchfa-aws added the 6 - Done but waiting to merge PR: The work is done and ready to merge label Oct 16, 2024
@Swiddis
Copy link
Contributor Author

Swiddis commented Oct 23, 2024

@kolchfa-aws merged in SQL, ready to merge here now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 - Done but waiting to merge PR: The work is done and ready to merge release-notes PR: Include this PR in the automated release notes v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants