feat: hide default dashboard setting when workspace is enabled #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yulong Ruan <[email protected]>
…rd-on-advance-settings-page-when-workspace-enable
TackAdam
approved these changes
Oct 10, 2024
…rd-on-advance-settings-page-when-workspace-enable
…rd-on-advance-settings-page-when-workspace-enable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2198 +/- ##
==========================================
- Coverage 56.58% 56.31% -0.28%
==========================================
Files 389 391 +2
Lines 14954 15124 +170
Branches 4059 4054 -5
==========================================
+ Hits 8462 8517 +55
- Misses 6430 6546 +116
+ Partials 62 61 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…rd-on-advance-settings-page-when-workspace-enable
ps48
approved these changes
Oct 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Yulong Ruan <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit dac7c2c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam
added a commit
that referenced
this pull request
Oct 17, 2024
#2208) (cherry picked from commit dac7c2c) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When workspace is enabled, the default dashboard setting becomes workspace specific, we need to hide it from the global advance settings page.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.