Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove ag grid package #2001

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Jul 26, 2024

Description

Removing this library due to critical CVE-2024-38996.
Upgrading to 32.0.2 uses ES2020. Hence removing the usage and disabling data table to unblock 2.16 release.

Known failure on test for windows and linux build:
Summary of all failing tests
FAIL public/components/event_analytics/explorer/query_assist/tests/input.test.tsx (6.879 s)

View with table removed: (User's can go to events to see the removed contents of the table).
Screenshot 2024-07-26 at 1 30 56 PM

Old Table:
Screenshot 2024-07-26 at 3 22 55 PM

Issues Resolved

#1910

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Adam Tackett <[email protected]>
@TackAdam TackAdam changed the title [Bug] Remove ag grid [Bug] Remove ag grid package Jul 26, 2024
@ps48 ps48 added bug Something isn't working backport 2.x backport 2.16 labels Jul 26, 2024
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
@ps48 ps48 merged commit 805c54f into opensearch-project:main Jul 26, 2024
11 of 20 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2001-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 805c54f771d1a963dc9f50407889c9674b5f03f9
# Push it to GitHub
git push --set-upstream origin backport/backport-2001-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2001-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.16
# Create a new branch
git switch --create backport/backport-2001-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 805c54f771d1a963dc9f50407889c9674b5f03f9
# Push it to GitHub
git push --set-upstream origin backport/backport-2001-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-2001-to-2.16.

TackAdam added a commit to TackAdam/dashboards-observability that referenced this pull request Jul 26, 2024
* remove ag grid

Signed-off-by: Adam Tackett <[email protected]>

* update yarn lock

Signed-off-by: Adam Tackett <[email protected]>

* update release notes

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
(cherry picked from commit 805c54f)
ps48 pushed a commit to ps48/dashboards-observability that referenced this pull request Jul 26, 2024
* remove ag grid

Signed-off-by: Adam Tackett <[email protected]>

* update yarn lock

Signed-off-by: Adam Tackett <[email protected]>

* update release notes

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
(cherry picked from commit 805c54f)
ps48 pushed a commit to ps48/dashboards-observability that referenced this pull request Jul 26, 2024
* remove ag grid

Signed-off-by: Adam Tackett <[email protected]>

* update yarn lock

Signed-off-by: Adam Tackett <[email protected]>

* update release notes

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
(cherry picked from commit 805c54f)
sumukhswamy pushed a commit that referenced this pull request Jul 29, 2024
* [Bug] CVE fix for ag (#1989)

* update package to fix CVEs

Signed-off-by: Adam Tackett <[email protected]>

* include yarnlock

Signed-off-by: Adam Tackett <[email protected]>

* change ag for cve

Signed-off-by: Adam Tackett <[email protected]>

* update release notes

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 196dd35)

* backport cve

Signed-off-by: Adam Tackett <[email protected]>

* update depend

Signed-off-by: Adam Tackett <[email protected]>

* update snapshots

Signed-off-by: Adam Tackett <[email protected]>

* [Bug] Remove ag grid package (#2001)

* remove ag grid

Signed-off-by: Adam Tackett <[email protected]>

* update yarn lock

Signed-off-by: Adam Tackett <[email protected]>

* update release notes

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
(cherry picked from commit 805c54f)

* quick fix

Signed-off-by: Adam Tackett <[email protected]>

* remove ag

Signed-off-by: Adam Tackett <[email protected]>

* update snapshots, remove securrity lakes from integrations, add import

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
ps48 added a commit that referenced this pull request Jul 29, 2024
* [Bug] Remove ag grid package (#2001)

* remove ag grid

Signed-off-by: Adam Tackett <[email protected]>

* update yarn lock

Signed-off-by: Adam Tackett <[email protected]>

* update release notes

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
(cherry picked from commit 805c54f)

* updated snapshots

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants